Open
Conversation
Collaborator
|
@amaanq thanks for the PR. Could you also update the script that generates bindings? |
amaanq
force-pushed
the
add-arm-ppc64-bindings
branch
from
2cd2592 to
349f62e
Compare
Author
|
Done, sorry for the delay |
Author
|
Any ETA on when we can get this in @richarddd? (It'll help us in tree-sitter to not have to always generate the bindings) |
amaanq
force-pushed
the
add-arm-ppc64-bindings
branch
from
398dc27 to
0293c50
Compare
Building on 32-bit ARM required a local `bindgen` and a cross toolchain since the crate didn't ship pre-generated bindings for `armv7-unknown-linux-gnueabihf`. This adds them directly, along with a CI matrix entry that installs the armhf cross packages and runs tests under `qemu-user`. Closes DelSkayn#95.
Building on 64-bit big-endian PowerPC required a local `bindgen` and a cross toolchain since the crate didn't ship pre-generated bindings for `powerpc64-unknown-linux-gnu`. This adds them directly, along with a CI matrix entry that installs the ppc64 cross packages and runs tests under `qemu-user`.
amaanq
force-pushed
the
add-arm-ppc64-bindings
branch
from
0293c50 to
0784c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Description of changes
This PR adds pre-generated bindgen output for armv7-unknown-linux-gnueabihf and powerpc64-unknown-linux-gnu so building on these targets doesn't require a local bindgen and cross toolchain. Each target gets a dedicated CI matrix entry that installs the cross-compilation packages and runs tests under qemu-user.
Checklist