Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 68.31% 68.51% +0.19%
==========================================
Files 83 83
Lines 12237 12300 +63
==========================================
+ Hits 8360 8427 +67
+ Misses 3877 3873 -4 ☔ View full report in Codecov by Sentry. |
|
The conflict with the |
|
I think this type should be called Also instead of implementing FromParams and IntoArgs maybe it should instead just implement |
|
Good point, I wasn't sure what we wanted to do with that since we have |
Missing Null implementations