Skip to content

fix(telemetry): wire up DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL to scheduler#1824

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
ayan.khan/fix-extended-heartbeat-interval-config
Apr 1, 2026
Merged

fix(telemetry): wire up DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL to scheduler#1824
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intomainfrom
ayan.khan/fix-extended-heartbeat-interval-config

Conversation

@khanayan123
Copy link
Copy Markdown
Contributor

@khanayan123 khanayan123 commented Mar 31, 2026 •
edited
Loading

Summary

Wire up the DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL config value to the telemetry scheduler. The env var was already parsed into config.telemetry_extended_heartbeat_interval but the scheduler hardcoded Duration::from_secs(60 * 60 * 24) instead of using it.

Default remains 24h this only enables system tests to use a shorter interval to validate the app-extended-heartbeat event fires correctly.

Changes

  • libdd-telemetry/src/worker/mod.rs: Replace hardcoded 60 * 60 * 24 with config.telemetry_extended_heartbeat_interval

Motivation

Cross-SDK system tests need to set a short extended heartbeat interval (e.g., 2s) to validate parity of the app-extended-heartbeat telemetry event across all SDKs. Without this fix, PHP and other libdatadog consumers cannot be system-tested for this feature.

Related

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/ayan.khan/fix-extended-heartbeat-interval-config

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 13 13 No change (0%)
Total 13 13 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-telemetry/src/worker/mod.rs 13 13 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 20 20 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 55 55 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 195 195 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

khanayan123 and others added 2 commits March 30, 2026 23:53
@khanayan123 @claude
fix(telemetry): use configured extended heartbeat interval instead of…
68565e7 
… hardcoded 24h

DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL was parsed from the environment
into config but never used — the scheduler hardcoded 24h. This wires up
the config value so the interval is actually configurable for testing.

The default remains 24h (set in config.rs). This only matters for system
tests that need a shorter interval to validate the event fires.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 @claude
fix(telemetry): add telemetry_extended_heartbeat_interval to Config s…
41bd935 
…truct

The field was only on Settings but not propagated to Config, which is
what the worker actually uses.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 khanayan123 force-pushed the ayan.khan/fix-extended-heartbeat-interval-config branch from ec4aceb to 41bd935 Compare March 31, 2026 03:53
@khanayan123 khanayan123 marked this pull request as ready for review March 31, 2026 03:59
@khanayan123 khanayan123 requested a review from a team as a code owner March 31, 2026 03:59
@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Mar 31, 2026 •
edited by datadog-datadog-prod-us1 bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.56% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 738d28e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.56%. Comparing base (0a2a9a8) to head (738d28e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         426      426           
  Lines       67048    67072   +24     
=======================================
+ Hits        47981    48000   +19     
- Misses      19067    19072    +5
Components Coverage Δ
libdd-crashtracker 66.03% <ø> (ø)
libdd-crashtracker-ffi 34.09% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.45% <ø> (ø)
libdd-data-pipeline-ffi 73.71% <ø> (ø)
libdd-common 79.94% <ø> (+0.23%) ⬆️
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.78% <100.00%> (+0.29%) ⬆️
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 72.56% <ø> (ø)
libdd-profiling 82.04% <ø> (-0.02%) ⬇️
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 31.35% <ø> (ø)
datdog-sidecar-ffi 11.84% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.24% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 88.73% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 31, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-31 04:11:33

Comparing candidate commit 41bd935 in PR branch ayan.khan/fix-extended-heartbeat-interval-config with baseline commit 15860bb in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:receiver_entry_point/report/2598

  • 🟥 execution_time [+185.273µs; +198.029µs] or [+5.381%; +5.751%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 14.862ms 14.898ms ± 0.016ms 14.896ms ± 0.009ms 14.906ms 14.921ms 14.958ms 14.961ms 0.44% 0.956 2.487 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [14.895ms; 14.900ms] or [-0.015%; +0.015%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 145.159µs 147.372µs ± 2.612µs 146.961µs ± 0.649µs 147.689µs 149.221µs 156.057µs 175.839µs 19.65% 7.692 74.467 1.77% 0.185µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [147.010µs; 147.734µs] or [-0.246%; +0.246%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 5.350µs 5.490µs ± 0.044µs 5.492µs ± 0.032µs 5.522µs 5.556µs 5.570µs 5.646µs 2.81% -0.068 0.163 0.80% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [5.484µs; 5.496µs] or [-0.111%; +0.111%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_timestamped_x1000 execution_time 4.185ms 4.191ms ± 0.010ms 4.190ms ± 0.002ms 4.192ms 4.196ms 4.200ms 4.324ms 3.18% 12.167 160.201 0.23% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_timestamped_x1000 execution_time [4.190ms; 4.193ms] or [-0.033%; +0.033%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.763ms 14.828ms ± 0.032ms 14.826ms ± 0.016ms 14.842ms 14.872ms 14.912ms 15.045ms 1.48% 2.279 13.093 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.824ms; 14.833ms] or [-0.029%; +0.029%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.953µs 34.726µs ± 1.361µs 34.085µs ± 0.049µs 34.196µs 37.640µs 37.672µs 37.704µs 10.62% 1.652 0.763 3.91% 0.096µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.537µs; 34.914µs] or [-0.543%; +0.543%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.346µs 206.299µs ± 0.524µs 206.221µs ± 0.358µs 206.658µs 207.205µs 207.593µs 207.836µs 0.78% 0.422 -0.209 0.25% 0.037µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4811496.616op/s 4847362.138op/s ± 12304.873op/s 4849154.914op/s ± 8428.396op/s 4856161.003op/s 4866540.777op/s 4868572.761op/s 4869825.613op/s 0.43% -0.410 -0.226 0.25% 870.086op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.577µs 18.678µs ± 0.055µs 18.670µs ± 0.031µs 18.702µs 18.779µs 18.849µs 18.980µs 1.66% 1.606 4.677 0.29% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52686050.966op/s 53538698.803op/s ± 157032.494op/s 53562410.994op/s ± 89141.934op/s 53647184.547op/s 53726411.544op/s 53749219.863op/s 53829759.281op/s 0.50% -1.571 4.470 0.29% 11103.874op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.526µs 10.782µs ± 0.122µs 10.774µs ± 0.078µs 10.861µs 11.005µs 11.052µs 11.101µs 3.04% 0.214 -0.394 1.13% 0.009µs 1 200
normalization/normalize_name/normalize_name/good throughput 90080487.947op/s 92763033.447op/s ± 1045764.206op/s 92817288.690op/s ± 673437.588op/s 93422170.264op/s 94482789.274op/s 94858427.069op/s 95004365.849op/s 2.36% -0.161 -0.423 1.12% 73946.696op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.226µs; 206.372µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4845656.801op/s; 4849067.476op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.671µs; 18.686µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53516935.610op/s; 53560461.997op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.765µs; 10.798µs] or [-0.157%; +0.157%] None None None
normalization/normalize_name/normalize_name/good throughput [92618100.586op/s; 92907966.308op/s] or [-0.156%; +0.156%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.421µs 162.484µs ± 0.315µs 162.449µs ± 0.162µs 162.626µs 163.031µs 163.472µs 163.917µs 0.90% 0.870 3.276 0.19% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.441µs; 162.528µs] or [-0.027%; +0.027%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.179ns 192.635ns ± 2.082ns 192.347ns ± 1.347ns 193.541ns 197.520ns 198.503ns 198.792ns 3.35% 1.115 0.840 1.08% 0.147ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.346ns; 192.923ns] or [-0.150%; +0.150%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 756.259µs 757.366µs ± 0.581µs 757.252µs ± 0.236µs 757.512µs 758.719µs 759.286µs 759.834µs 0.34% 1.533 3.237 0.08% 0.041µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [757.286µs; 757.447µs] or [-0.011%; +0.011%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 288.042µs 288.923µs ± 0.565µs 288.830µs ± 0.177µs 289.027µs 289.611µs 291.490µs 293.272µs 1.54% 4.121 23.573 0.20% 0.040µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [288.844µs; 289.001µs] or [-0.027%; +0.027%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 14.866µs 15.310µs ± 0.184µs 15.298µs ± 0.091µs 15.394µs 15.594µs 15.751µs 16.473µs 7.68% 1.482 7.794 1.20% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [15.285µs; 15.336µs] or [-0.167%; +0.167%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.968µs 5.039µs ± 0.039µs 5.041µs ± 0.039µs 5.062µs 5.101µs 5.103µs 5.106µs 1.29% 0.180 -1.200 0.77% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.034µs; 5.045µs] or [-0.108%; +0.108%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.596ms 3.635ms ± 0.023ms 3.630ms ± 0.014ms 3.647ms 3.680ms 3.698ms 3.713ms 2.29% 0.940 0.452 0.63% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.632ms; 3.638ms] or [-0.087%; +0.087%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.346µs 2.405µs ± 0.015µs 2.406µs ± 0.004µs 2.411µs 2.423µs 2.434µs 2.441µs 1.44% -1.708 4.710 0.62% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.403µs; 2.407µs] or [-0.086%; +0.086%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.294ns 254.901ns ± 13.816ns 249.777ns ± 2.655ns 254.384ns 288.463ns 302.539ns 305.261ns 22.21% 2.245 4.094 5.41% 0.977ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.986ns; 256.816ns] or [-0.751%; +0.751%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.905µs 3.915µs ± 0.004µs 3.914µs ± 0.002µs 3.918µs 3.922µs 3.923µs 3.925µs 0.26% 0.452 -0.349 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 254809390.110op/s 255397136.315op/s ± 229665.775op/s 255466342.317op/s ± 145788.226op/s 255567552.894op/s 255692972.766op/s 255775247.418op/s 256079559.259op/s 0.24% -0.448 -0.349 0.09% 16239.823op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 74.888µs 77.340µs ± 0.879µs 77.332µs ± 0.625µs 77.964µs 78.761µs 79.295µs 79.466µs 2.76% -0.097 -0.264 1.13% 0.062µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12584051.786op/s 12931513.455op/s ± 147166.885op/s 12931319.195op/s ± 104108.449op/s 13034124.663op/s 13172087.331op/s 13261225.867op/s 13353255.020op/s 3.26% 0.156 -0.239 1.14% 10406.270op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 67.481µs 67.692µs ± 0.112µs 67.682µs ± 0.068µs 67.749µs 67.861µs 67.944µs 68.428µs 1.10% 1.554 7.894 0.17% 0.008µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 14613889.198op/s 14772750.142op/s ± 24430.075op/s 14774890.077op/s ± 14786.637op/s 14789765.113op/s 14807491.629op/s 14813644.590op/s 14819029.115op/s 0.30% -1.517 7.610 0.16% 1727.467op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.899µs 3.916µs ± 0.004µs 3.915µs ± 0.002µs 3.918µs 3.922µs 3.924µs 3.930µs 0.39% 0.258 2.522 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254420721.985op/s 255391696.494op/s ± 239933.019op/s 255413199.130op/s ± 150043.788op/s 255556610.788op/s 255696575.169op/s 255784155.463op/s 256507921.453op/s 0.43% -0.245 2.540 0.09% 16965.826op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 64.510µs 64.716µs ± 0.079µs 64.709µs ± 0.046µs 64.765µs 64.838µs 64.941µs 64.978µs 0.42% 0.390 0.707 0.12% 0.006µs 1 200
credit_card/is_card_number/378282246310005 throughput 15389795.215op/s 15452262.521op/s ± 18881.785op/s 15453703.794op/s ± 11023.342op/s 15463619.516op/s 15483726.759op/s 15490069.071op/s 15501367.221op/s 0.31% -0.380 0.694 0.12% 1335.144op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.720µs 44.964µs ± 0.091µs 44.966µs ± 0.061µs 45.019µs 45.119µs 45.175µs 45.198µs 0.52% 0.048 -0.114 0.20% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22124699.369op/s 22240012.465op/s ± 44825.146op/s 22239036.133op/s ± 30183.111op/s 22269658.150op/s 22314751.405op/s 22333987.238op/s 22361267.637op/s 0.55% -0.037 -0.116 0.20% 3169.616op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.695µs 5.705µs ± 0.007µs 5.704µs ± 0.004µs 5.709µs 5.714µs 5.723µs 5.767µs 1.12% 3.532 25.903 0.13% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 173385649.049op/s 175285146.977op/s ± 222201.340op/s 175319206.220op/s ± 128980.052op/s 175437424.523op/s 175516394.166op/s 175548076.995op/s 175583057.447op/s 0.15% -3.474 25.228 0.13% 15712.007op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.916µs ± 0.004µs 3.915µs ± 0.003µs 3.919µs 3.923µs 3.926µs 3.929µs 0.35% -0.130 2.539 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254529889.572op/s 255376908.466op/s ± 282976.839op/s 255418147.465op/s ± 195741.790op/s 255580433.397op/s 255706517.967op/s 255801740.508op/s 256829409.763op/s 0.55% 0.145 2.599 0.11% 20009.484op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 59.513µs 60.387µs ± 0.480µs 60.308µs ± 0.286µs 60.716µs 61.201µs 61.485µs 61.807µs 2.49% 0.428 -0.207 0.79% 0.034µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 16179365.992op/s 16560760.223op/s ± 131293.439op/s 16581658.634op/s ± 79053.646op/s 16640691.225op/s 16765819.147op/s 16799229.507op/s 16802938.834op/s 1.33% -0.390 -0.250 0.79% 9283.848op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.494µs 53.797µs ± 0.102µs 53.795µs ± 0.069µs 53.866µs 53.974µs 54.026µs 54.072µs 0.51% 0.064 -0.043 0.19% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18493889.303op/s 18588376.583op/s ± 35310.369op/s 18589086.357op/s ± 23702.075op/s 18611085.078op/s 18644434.275op/s 18667386.772op/s 18693672.192op/s 0.56% -0.053 -0.041 0.19% 2496.820op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.899µs 3.916µs ± 0.004µs 3.916µs ± 0.003µs 3.919µs 3.923µs 3.927µs 3.932µs 0.43% 0.543 1.887 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254297594.498op/s 255360304.248op/s ± 264657.040op/s 255393653.469op/s ± 184376.594op/s 255563317.757op/s 255666327.614op/s 255719561.495op/s 256455802.895op/s 0.42% -0.532 1.888 0.10% 18714.079op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.207µs 50.341µs ± 0.074µs 50.337µs ± 0.044µs 50.376µs 50.481µs 50.516µs 50.792µs 0.90% 1.448 5.834 0.15% 0.005µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19688250.893op/s 19864410.353op/s ± 29246.932op/s 19866254.187op/s ± 17377.090op/s 19885230.246op/s 19902408.891op/s 19913765.196op/s 19917567.294op/s 0.26% -1.423 5.663 0.15% 2068.070op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.703µs 44.944µs ± 0.075µs 44.939µs ± 0.055µs 44.993µs 45.077µs 45.117µs 45.179µs 0.53% 0.186 0.079 0.17% 0.005µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22134265.262op/s 22249968.804op/s ± 37212.387op/s 22252478.719op/s ± 27354.265op/s 22279835.079op/s 22303140.217op/s 22324431.077op/s 22370015.913op/s 0.53% -0.176 0.078 0.17% 2631.313op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.695µs 5.704µs ± 0.006µs 5.703µs ± 0.003µs 5.708µs 5.714µs 5.721µs 5.739µs 0.63% 1.724 6.758 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 174234642.280op/s 175301838.245op/s ± 175211.928op/s 175339977.515op/s ± 104510.547op/s 175420886.967op/s 175522665.426op/s 175565503.681op/s 175603583.475op/s 0.15% -1.707 6.636 0.10% 12389.354op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.915µs; 3.916µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ throughput [255365306.847op/s; 255428965.782op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.219µs; 77.462µs] or [-0.157%; +0.157%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12911117.540op/s; 12951909.370op/s] or [-0.158%; +0.158%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [67.677µs; 67.708µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14769364.368op/s; 14776135.915op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/37828224631 execution_time [3.915µs; 3.916µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [255358444.085op/s; 255424948.903op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [64.705µs; 64.727µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/378282246310005 throughput [15449645.688op/s; 15454879.355op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [44.952µs; 44.977µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22233800.131op/s; 22246224.799op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.704µs; 5.706µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/x371413321323331 throughput [175254352.008op/s; 175315941.945op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.915µs; 3.916µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [255337690.598op/s; 255416126.334op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [60.321µs; 60.454µs] or [-0.110%; +0.110%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [16542564.215op/s; 16578956.230op/s] or [-0.110%; +0.110%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.783µs; 53.811µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18583482.905op/s; 18593270.260op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.915µs; 3.917µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255323625.327op/s; 255396983.168op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.331µs; 50.352µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19860357.009op/s; 19868463.696op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [44.934µs; 44.954µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22244811.525op/s; 22255126.083op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.704µs; 5.705µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [175277555.557op/s; 175326120.933op/s] or [-0.014%; +0.014%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.661µs 536.174µs ± 1.408µs 535.737µs ± 0.445µs 536.405µs 539.242µs 542.177µs 543.361µs 1.42% 2.500 7.523 0.26% 0.100µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1840397.483op/s 1865077.685op/s ± 4865.574op/s 1866587.113op/s ± 1552.042op/s 1867914.030op/s 1869431.061op/s 1869902.288op/s 1870344.012op/s 0.20% -2.474 7.361 0.26% 344.048op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.101µs 381.051µs ± 0.435µs 380.963µs ± 0.283µs 381.344µs 381.937µs 382.144µs 382.274µs 0.34% 0.664 -0.085 0.11% 0.031µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2615922.621op/s 2624323.065op/s ± 2994.967op/s 2624923.835op/s ± 1945.196op/s 2626539.688op/s 2628182.488op/s 2628638.734op/s 2630882.095op/s 0.23% -0.659 -0.093 0.11% 211.776op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.629µs 190.485µs ± 0.428µs 190.428µs ± 0.339µs 190.824µs 191.218µs 191.464µs 191.610µs 0.62% 0.364 -0.684 0.22% 0.030µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5218923.119op/s 5249771.806op/s ± 11783.574op/s 5251340.253op/s ± 9333.957op/s 5258754.486op/s 5265845.537op/s 5269587.722op/s 5273467.845op/s 0.42% -0.356 -0.692 0.22% 833.225op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.835µs 37.934µs ± 0.052µs 37.926µs ± 0.033µs 37.964µs 38.021µs 38.089µs 38.112µs 0.49% 0.755 0.670 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26238657.084op/s 26361939.403op/s ± 36264.671op/s 26366838.352op/s ± 23077.044op/s 26386893.963op/s 26411494.114op/s 26428428.135op/s 26430390.581op/s 0.24% -0.746 0.650 0.14% 2564.299op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.788µs 46.040µs ± 0.175µs 45.998µs ± 0.083µs 46.105µs 46.299µs 46.411µs 47.716µs 3.73% 4.643 40.025 0.38% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20957164.952op/s 21720464.567op/s ± 81334.205op/s 21739894.482op/s ± 39440.922op/s 21770525.509op/s 21801308.927op/s 21816750.971op/s 21839629.658op/s 0.46% -4.416 37.096 0.37% 5751.197op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.979µs; 536.369µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1864403.363op/s; 1865752.006op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.991µs; 381.111µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2623907.992op/s; 2624738.139op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.426µs; 190.545µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5248138.716op/s; 5251404.896op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.926µs; 37.941µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26356913.468op/s; 26366965.338op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.016µs; 46.064µs] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21709192.429op/s; 21731736.706op/s] or [-0.052%; +0.052%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.133ms 4.138ms ± 0.003ms 4.138ms ± 0.001ms 4.139ms 4.141ms 4.145ms 4.172ms 0.83% 6.134 62.145 0.08% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.138ms; 4.138ms] or [-0.011%; +0.011%] None None None

Group 20

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_serialize_compressed_pprof_timestamped_x1000 execution_time 912.373µs 916.478µs ± 2.694µs 915.912µs ± 1.048µs 917.007µs 920.617µs 924.914µs 939.054µs 2.53% 3.680 24.225 0.29% 0.190µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_serialize_compressed_pprof_timestamped_x1000 execution_time [916.105µs; 916.852µs] or [-0.041%; +0.041%] None None None

Group 21

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 41bd935 1774929222 ayan.khan/fix-extended-heartbeat-interval-config
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.570ms 48.880ms ± 0.916ms 48.737ms ± 0.057ms 48.819ms 49.017ms 51.196ms 59.588ms 22.27% 9.518 99.891 1.87% 0.065ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.753ms; 49.007ms] or [-0.260%; +0.260%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 31, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 102.11 MB 102.11 MB -0% (-96 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 119.08 MB 119.08 MB -0% (-16 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.36 MB 11.36 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.42 MB 27.41 MB -0% (-1.00 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 187.83 MB 187.83 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 924.51 MB 924.51 MB +0% (+322 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.06 MB 9.06 MB --.01% (-1.00 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 27.01 MB 27.01 MB +.02% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 61.33 MB 61.33 MB -0% (-766 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.27 MB 23.27 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 192.40 MB 192.40 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 909.65 MB 909.65 MB +0% (+750 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.90 MB 6.90 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 29.12 MB 29.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 57.70 MB 57.70 MB +0% (+16 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 88.96 MB 88.96 MB -0% (-536 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.34 MB 10.34 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 111.75 MB 111.75 MB -0% (-1.33 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.09 MB 12.09 MB 0% (0 B) 👌

ekump
ekump reviewed Mar 31, 2026
View reviewed changes
khanayan123 and others added 2 commits March 31, 2026 12:29
@khanayan123 @claude
test(telemetry): add unit tests for extended heartbeat interval propa…
5ae72b2 
…gation

Verify that Config::from_settings() correctly propagates a custom
extended_heartbeat_interval from Settings, and that the default
value is 24h.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 @claude
test(telemetry): add env var test for DD_TELEMETRY_EXTENDED_HEARTBEAT…
8707073 
…_INTERVAL

Verify the full env var → Settings::from_env() → Config flow by setting
DD_TELEMETRY_EXTENDED_HEARTBEAT_INTERVAL=5 and asserting the parsed
duration is 5s.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 khanayan123 requested a review from ekump March 31, 2026 16:35
ekump
ekump reviewed Mar 31, 2026
View reviewed changes
libdd-telemetry/src/config.rs Outdated
fn test_extended_heartbeat_interval_from_env() {
use std::time::Duration;

// SAFETY: env var tests in this repo use set_var directly; run with
Copy link
Copy Markdown
Contributor

@ekump ekump Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use EnvGuard for this.

ekump
ekump reviewed Mar 31, 2026
View reviewed changes
libdd-telemetry/src/config.rs Outdated
use std::time::Duration;

// SAFETY: env var tests in this repo use set_var directly; run with
// --test-threads=1 if parallel env mutation is a concern.
Copy link
Copy Markdown
Contributor

@ekump ekump Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextest runs tests in isolated processes. This shouldn't be a concern. No one should be running libdatadog tests with cargo test.

khanayan123 and others added 2 commits March 31, 2026 13:20
@khanayan123 @claude
refactor(telemetry): use EnvGuard in extended heartbeat env var test
13d6d59 
Address review feedback: use EnvGuard from libdd-common test_utils
instead of raw set_var/remove_var. Add libdd-common test-utils feature
to dev-dependencies.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 @claude
style: fix rustfmt formatting
8db5dfc 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 khanayan123 requested a review from ekump March 31, 2026 17:29
ekump
ekump approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of components reading config from env vars directly, they should be passed in via the SDKs at config time. But for some reason, that's not how this component was designed, so at least this is consistent. LGTM.

@khanayan123
Copy link
Copy Markdown
Contributor Author

khanayan123 commented Mar 31, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 31, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-31 18:06:26 UTC ℹ️ Start processing command /merge

2026-03-31 18:06:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-03-31 19:35:01 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

@khanayan123
Copy link
Copy Markdown
Contributor Author

khanayan123 commented Mar 31, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 31, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-31 19:35:22 UTC ℹ️ Start processing command /merge

2026-03-31 19:35:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-04-01 00:18:14 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@khanayan123
Copy link
Copy Markdown
Contributor Author

khanayan123 commented Apr 1, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 1, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-01 03:49:01 UTC ℹ️ Start processing command /merge

2026-04-01 03:49:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-04-01 08:36:17 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit f1f0df1 into main Apr 1, 2026
151 of 153 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the ayan.khan/fix-extended-heartbeat-interval-config branch April 1, 2026 12:50
@khanayan123 khanayan123 mentioned this pull request Apr 1, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekump ekump ekump approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khanayan123 @codecov-commenter @ekump