-
Notifications
You must be signed in to change notification settings - Fork 480
fix(profiling): honor gunicorn --graceful-timeout when gevent is used
#16424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate taegyunkim/fix-scp-1077 (76244d0) with baseline main (1859292) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 104.856µs (SLO: <130.000µs 📉 -19.3%) vs baseline: +2.7% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 102.538µs (SLO: <130.000µs 📉 -21.1%) vs baseline: +0.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 28.371µs (SLO: <40.000µs 📉 -29.1%) vs baseline: +0.6% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.2% ✅ add_noaspectTime: ✅ 49.233µs (SLO: <70.000µs 📉 -29.7%) vs baseline: +0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ bytearray_aspectTime: ✅ 251.324µs (SLO: <400.000µs 📉 -37.2%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 636.156µs (SLO: <800.000µs 📉 -20.5%) vs baseline: +1.0% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 266.082µs (SLO: <400.000µs 📉 -33.5%) vs baseline: +0.1% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.3% ✅ bytearray_noaspectTime: ✅ 139.365µs (SLO: <300.000µs 📉 -53.5%) vs baseline: -1.1% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 216.018µs (SLO: <300.000µs 📉 -28.0%) vs baseline: -1.1% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 134.507µs (SLO: <200.000µs 📉 -32.7%) vs baseline: +0.6% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 3.910ms (SLO: <5.000ms 📉 -21.8%) vs baseline: +0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 315.214µs (SLO: <420.000µs 📉 -24.9%) vs baseline: +0.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 89.391µs (SLO: <300.000µs 📉 -70.2%) vs baseline: -0.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 265.994µs (SLO: <300.000µs 📉 -11.3%) vs baseline: +3.6% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 89.434µs (SLO: <500.000µs 📉 -82.1%) vs baseline: -0.4% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 314.816µs (SLO: <500.000µs 📉 -37.0%) vs baseline: -0.7% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.4% ✅ decode_aspectTime: ✅ 88.149µs (SLO: <100.000µs 📉 -11.9%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 151.909µs (SLO: <210.000µs 📉 -27.7%) vs baseline: -1.0% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 85.390µs (SLO: <200.000µs 📉 -57.3%) vs baseline: -0.6% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ encode_noaspectTime: ✅ 141.141µs (SLO: <200.000µs 📉 -29.4%) vs baseline: -0.5% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 14.605ms (SLO: <19.200ms 📉 -23.9%) vs baseline: +0.2% Memory: ✅ 43.185MB (SLO: <46.000MB -6.1%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.394ms (SLO: <21.500ms 📉 -23.7%) vs baseline: +0.3% Memory: ✅ 43.195MB (SLO: <46.000MB -6.1%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 368.572µs (SLO: <500.000µs 📉 -26.3%) vs baseline: -0.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 303.060µs (SLO: <500.000µs 📉 -39.4%) vs baseline: -1.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ index_aspectTime: ✅ 129.826µs (SLO: <300.000µs 📉 -56.7%) vs baseline: +5.0% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.128µs (SLO: <300.000µs 📉 -86.6%) vs baseline: -0.8% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 215.168µs (SLO: <300.000µs 📉 -28.3%) vs baseline: +0.8% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +5.3% ✅ join_noaspectTime: ✅ 146.613µs (SLO: <300.000µs 📉 -51.1%) vs baseline: +1.0% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 565.242µs (SLO: <700.000µs 📉 -19.3%) vs baseline: 📈 +15.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ ljust_noaspectTime: ✅ 257.084µs (SLO: <300.000µs 📉 -14.3%) vs baseline: +1.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 301.885µs (SLO: <500.000µs 📉 -39.6%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ lower_noaspectTime: ✅ 234.932µs (SLO: <300.000µs 📉 -21.7%) vs baseline: -0.9% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 0.279ms (SLO: <3.000ms 📉 -90.7%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.177ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ modulo_aspectTime: ✅ 14.256ms (SLO: <18.750ms 📉 -24.0%) vs baseline: ~same Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.800ms (SLO: <19.350ms 📉 -23.5%) vs baseline: +0.4% Memory: ✅ 43.107MB (SLO: <46.000MB -6.3%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 14.373ms (SLO: <18.900ms 📉 -24.0%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.570ms (SLO: <19.150ms 📉 -23.9%) vs baseline: +0.4% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.367ms (SLO: <3.000ms 📉 -87.8%) vs baseline: +1.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ replace_aspectTime: ✅ 18.390ms (SLO: <24.000ms 📉 -23.4%) vs baseline: +0.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 283.611µs (SLO: <300.000µs -5.5%) vs baseline: +1.4% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 317.846µs (SLO: <420.000µs 📉 -24.3%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 46.732µs (SLO: <90.000µs 📉 -48.1%) vs baseline: -0.2% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 375.527µs (SLO: <500.000µs 📉 -24.9%) vs baseline: +0.9% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 181.290µs (SLO: <300.000µs 📉 -39.6%) vs baseline: +0.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 182.293µs (SLO: <300.000µs 📉 -39.2%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 53.711µs (SLO: <90.000µs 📉 -40.3%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 4.455ms (SLO: <5.000ms 📉 -10.9%) vs baseline: 📈 +12.6% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 347.547µs (SLO: <500.000µs 📉 -30.5%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 275.694µs (SLO: <350.000µs 📉 -21.2%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ strip_noaspectTime: ✅ 176.312µs (SLO: <240.000µs 📉 -26.5%) vs baseline: -0.9% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.4% ✅ swapcase_aspectTime: ✅ 336.513µs (SLO: <500.000µs 📉 -32.7%) vs baseline: -0.4% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 274.720µs (SLO: <400.000µs 📉 -31.3%) vs baseline: -0.7% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 325.270µs (SLO: <500.000µs 📉 -34.9%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 262.791µs (SLO: <400.000µs 📉 -34.3%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 493.442µs (SLO: <700.000µs 📉 -29.5%) vs baseline: +0.3% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 424.257µs (SLO: <500.000µs 📉 -15.1%) vs baseline: -0.8% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 299.271µs (SLO: <500.000µs 📉 -40.1%) vs baseline: ~same Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ upper_noaspectTime: ✅ 234.074µs (SLO: <400.000µs 📉 -41.5%) vs baseline: -0.8% Memory: ✅ 43.234MB (SLO: <46.000MB -6.0%) vs baseline: +5.4% 📈 iastaspectsospath - 23/23✅ ospathbasename_aspectTime: ✅ 497.278µs (SLO: <700.000µs 📉 -29.0%) vs baseline: 📈 +16.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 429.526µs (SLO: <700.000µs 📉 -38.6%) vs baseline: -0.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 619.488µs (SLO: <700.000µs 📉 -11.5%) vs baseline: +1.0% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 625.154µs (SLO: <700.000µs 📉 -10.7%) vs baseline: +0.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 354.096µs (SLO: <700.000µs 📉 -49.4%) vs baseline: +0.8% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ ospathnormcase_noaspectTime: ✅ 360.892µs (SLO: <700.000µs 📉 -48.4%) vs baseline: +0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 490.434µs (SLO: <700.000µs 📉 -29.9%) vs baseline: +0.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 496.871µs (SLO: <700.000µs 📉 -29.0%) vs baseline: +0.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 372.173µs (SLO: <700.000µs 📉 -46.8%) vs baseline: -1.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ ospathsplitdrive_noaspectTime: ✅ 73.319µs (SLO: <700.000µs 📉 -89.5%) vs baseline: +0.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 457.368µs (SLO: <700.000µs 📉 -34.7%) vs baseline: -1.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 466.421µs (SLO: <700.000µs 📉 -33.4%) vs baseline: -0.6% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.406µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +17.2% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 201.745µs (SLO: <220.000µs -8.3%) vs baseline: +0.4% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.265µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +0.6% Memory: ✅ 35.704MB (SLO: <38.000MB -6.0%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.887µs (SLO: <230.000µs -7.4%) vs baseline: -0.5% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.217µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.2% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.783µs (SLO: <150.000µs -9.5%) vs baseline: -0.6% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.042µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -1.0% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 216.224µs (SLO: <250.000µs 📉 -13.5%) vs baseline: +0.9% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.183ms (SLO: <22.000ms -8.3%) vs baseline: -0.6% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.235ms (SLO: <2.550ms 📉 -12.3%) vs baseline: +0.4% Memory: ✅ 35.763MB (SLO: <38.000MB -5.9%) vs baseline: +5.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.401ms (SLO: <1.550ms -9.6%) vs baseline: +0.4% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.196ms (SLO: <2.550ms 📉 -13.9%) vs baseline: -0.2% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.512µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +0.6% Memory: ✅ 35.645MB (SLO: <38.000MB -6.2%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 175.376µs (SLO: <250.000µs 📉 -29.8%) vs baseline: +0.7% Memory: ✅ 35.645MB (SLO: <38.000MB -6.2%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.176ms (SLO: <2.500ms 📉 -12.9%) vs baseline: +0.2% Memory: ✅ 36.431MB (SLO: <38.750MB -6.0%) vs baseline: +5.1%
|
Description
Testing
Risks
Additional Notes