Skip to content

Set PHP-specific injection package size ratchet#3762

Open
lloeki wants to merge 1 commit intomasterfrom
lloeki/injection-size-ratchet
Open

Set PHP-specific injection package size ratchet#3762
lloeki wants to merge 1 commit intomasterfrom
lloeki/injection-size-ratchet

Conversation

@lloeki
Copy link
Copy Markdown
Member

@lloeki lloeki commented Apr 1, 2026

Description

Due to a change PHP-side libdatadog was bumped to v29. This version bump caused PHP images to blow past their previous limit.

Simultaneously, changes to the datadog-package binary were picked up. Notably the github.com/klauspost/compress/zstd dependency was bumped from 1.17.4 to 1.18.1. This bump included in 1.17.5 a default value change for the compression context size, downscaled from 32MB to 8MB (fixing compatibility with browsers like Chrome), causing drastic changes in compression results.

Unbeknownst to the second change, PHP therefore updated the global limits, attributing the size change to the libdatadog bump (which was true, but not for the whole of it):

This allowed a change to slip through to other languages, where the new datadog-package binary caused regressions in package size without change to the inputs. Due to the wildly differing sizes of packages across languages the regression is silent, rendering the size threshold ratchet moot.

To combat such silently creeping regressions, this PR introduces language-specific thresholds for the ratchet through one pipeline overrides

Note: datadog-package was fixed in https://github.com/DataDog/datadog-packages/pull/64 which may take some time to trickle down.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@lloeki lloeki requested a review from a team as a code owner April 1, 2026 12:59
@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Apr 1, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

❄️ Known flaky: testAsyncWithTracerDisabledOnConsume from symfony-latest-test.DDTrace\Tests\Integrations\Symfony\Latest\MessengerTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integrations\Symfony\Latest\MessengerTest::testAsyncWithTracerDisabledOnConsume
Command failed with exit code 1. Output: 
 [OK] Consuming messages from transport "async".

 // The worker will automatically exit once it has processed 1 messages or
 // received a stop signal via the messenger:stop-workers command.

 // Quit the worker with CONTROL-C.

 // Re-run the command with a -vv option to see logs about consumed messages.
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95fdb2f | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants