fix(laravel): use route URI instead of unnamed_route in resource name

[Leiyks]

Summary

When DD_HTTP_SERVER_ROUTE_BASED_NAMING is enabled (default), routes defined without a ->name() call produced resource names like:

App\Http\Controllers\API\v1\Apps\AppsController@getStripeConnectionToken unnamed_route

For unnamed routes, the unnamed_route suffix is now replaced with the actual route URI:

App\Http\Controllers\API\v1\Apps\AppsController@getStripeConnectionToken stripe/connection

Named routes are fully unaffected.

Fixes APMS-18982.

Root cause

LaravelIntegration::findRoute sets the resource to {action} {routeName}. For routes defined with the old string syntax (Route::get('path', 'Controller@method')) or any route without ->name(), normalizeRouteName() returns the constant 'unnamed_route'. There was no fallback — the literal string ended up in the resource.

[github-actions]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

9 occurrences of :

- "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route"
+ "resource": "App\\Http\\Controllers\\CommonSpecsController@error error"

7 occurrences of :

- "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route"
+ "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view"

3 occurrences of :

- "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute unnamed_route"
+ "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute dynamic_route/{param01}/static/{param02?}"

[datadog-datadog-prod-us1-2]

⚠️ Tests

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 4 Tests failed

testScenarioGetWithException from laravel-octane-latest-test.DDTrace\Tests\Integrations\Laravel\Octane\Latest\CommonScenariosTest     (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\Octane\Latest\CommonScenariosTest::testScenarioGetWithException
Cannot find span
  - Current level: root/root
  - Span not found: laravel.request/App\Http\Controllers\CommonSpecsController@error unnamed_route
Received Spans graph:
laravel.request (service: swoole_test_app, resource: App\Http\Controllers\CommonSpecsController@error error, type: web)
  runtime-id => 6d8cbb3b-c122-424c-822d-3cc4d94735bb
  http.url => http://localhost/error?key=value&<redacted>
  http.status_code => 500
  laravel.route.action => App\Http\Controllers\CommonSpecsController@error
...

testScenarioGetWithView from laravel-octane-latest-test.DDTrace\Tests\Integrations\Laravel\Octane\Latest\CommonScenariosTest     (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\Octane\Latest\CommonScenariosTest::testScenarioGetWithView
Cannot find span
  - Current level: root/root
  - Span not found: laravel.request/App\Http\Controllers\CommonSpecsController@simple_view unnamed_route
Received Spans graph:
laravel.request (service: swoole_test_app, resource: App\Http\Controllers\CommonSpecsController@simple_view simple_view, type: web)
  runtime-id => 6d8cbb3b-c122-424c-822d-3cc4d94735bb
  component => laravel
  laravel.route.action => App\Http\Controllers\CommonSpecsController@simple_view
  http.route => simple_view
...

❄️ Known flaky: testAsyncWithTracerDisabledOnConsume from symfony-latest-test.DDTrace\Tests\Integrations\Symfony\Latest\MessengerTest     (Fix with Cursor)

DDTrace\Tests\Integrations\Symfony\Latest\MessengerTest::testAsyncWithTracerDisabledOnConsume
Command failed with exit code 1. Output: 
 [OK] Consuming messages from transport "async".

 // The worker will automatically exit once it has processed 1 messages or
 // received a stop signal via the messenger:stop-workers command.

 // Quit the worker with CONTROL-C.

 // Re-run the command with a -vv option to see logs about consumed messages.
...

testScenario with data set "A GET request to a dynamic route returning a string" from tests/Integrations/Laravel/V4.DDTrace\Tests\Integrations\Laravel\V4\CommonScenariosTest.DDTrace\Tests\Integrations\Laravel\V4\CommonScenariosTest::testScenario     (Fix with Cursor)

DDTrace\Tests\Integrations\Laravel\V4\CommonScenariosTest::testScenario with data set "A GET request to a dynamic route returning a string" (DDTrace\Tests\Frameworks\Util\Request\GetSpec Object (...), array(DDTrace\Tests\Common\SpanAssertion Object (...)))
Cannot find span
  - Current level: root/root
  - Span not found: laravel.request/HomeController@dynamicRoute unnamed_route
Received Spans graph:
laravel.request (service: laravel, resource: HomeController@dynamicRoute dynamic_route/{param01}/static/{param02?}, type: web)
  runtime-id => c5dfbb75-bcb5-4f1a-ae25-0435fa1c12f6
  http.method => GET
  http.url => http://localhost/dynamic_route/dynamic01/static/dynamic02
  span.kind => server
...

View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.64% (-0.05%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4f6a72b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

[bwoebi]

Looks good, nice fix.