Skip to content

Update libdatadog to v30.0, make CA root optional for profiling#3758

Open
morrisonlevi wants to merge 2 commits intomasterfrom
levi/profiling-v30
Open

Update libdatadog to v30.0, make CA root optional for profiling#3758
morrisonlevi wants to merge 2 commits intomasterfrom
levi/profiling-v30

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Mar 30, 2026

Description

This supersedes #3734. In a recent libdatadog change, we unintentionally required that a CA root store be found even for non-HTTPS connections to the agent e.g. http:// and unix:// endpoints.

This PR targets the v30 release of libdatadog which includes the fix. It does this by updating the vendored libdatadog/ which was previously pointing to a commit on main to point to v30.0.0, and then updating the profiling/ crate to use path = "../libdatdog/....

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested review from a team as code owners March 30, 2026 20:11
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Mar 30, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (fd1ba67) to head (e45f220).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3758      +/-   ##
==========================================
- Coverage   68.85%   68.84%   -0.02%     
==========================================
  Files         166      166              
  Lines       19015    19015              
  Branches     1792     1792              
==========================================
- Hits        13093    13091       -2     
- Misses       5111     5114       +3     
+ Partials      811      810       -1     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (ø)
helper-rust-unit 49.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1ba67...e45f220. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 30, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-03-30 21:16:17

Comparing candidate commit e45f220 in PR branch levi/profiling-v30 with baseline commit fd1ba67 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 8 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟩 cpu_user_time [-276.286ms; -221.334ms] or [-17.288%; -13.850%]
  • 🟩 execution_time [-193.115ms; -105.785ms] or [-14.033%; -7.687%]

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Mar 30, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e45f220 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@morrisonlevi morrisonlevi changed the title fix(profiling): CA root is optional again fix(profiling): CA root is optional again, update libdatadog Mar 30, 2026
@morrisonlevi morrisonlevi changed the title fix(profiling): CA root is optional again, update libdatadog fix(profiling): CA root is optional again, update libdatadog to v30 Mar 30, 2026
@morrisonlevi morrisonlevi changed the title fix(profiling): CA root is optional again, update libdatadog to v30 fix(profiling): CA root is optional again, update libdatadog to v30.0 Mar 30, 2026
@morrisonlevi morrisonlevi changed the title fix(profiling): CA root is optional again, update libdatadog to v30.0 Update libdatadog to v30.0, make CA root optional for profiling Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants