Skip to content

Revert "chore(ci): add final_status property on junit XML [APMSP-2610]" #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbeauchesne merged 2 commits into from
Apr 2, 2026
+0 −73
Merged

Revert "chore(ci): add final_status property on junit XML [APMSP-2610]" #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b0589
Revert "chore(ci): add final_status property on junit XML [APMSP-2610…
cbeauchesne Apr 2, 2026
98eec81
Put back if condition
cbeauchesne Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions .github/workflows/add_final_status.xsl
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,6 @@ jobs:
run: cd ${BUILD_DIR} && test/tests -r junit -o report.xml
env:
ASAN_OPTIONS: alloc_dealloc_mismatch=0
- name: Add final_status property
if: success() || failure()
run: |
which xsltproc || (apt-get update && apt-get install -y xsltproc)
xml_file=".build/report.xml"
echo "Fixing $xml_file"
tmp_file="$(mktemp)"
xsltproc --output "$tmp_file" ".github/workflows/add_final_status.xsl" "$xml_file"
mv "$tmp_file" "$xml_file"
- name: Upload test report to Datadog
if: success() || failure()
run: |
Expand Down Expand Up @@ -165,20 +156,6 @@ jobs:
run: |
& 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\Common7\\Tools\\Launch-VsDevShell.ps1' -arch ${{ matrix.arch }}
.\build\test\tests.exe -r junit -o report.xml
- name: Add final_status property
if: success() || failure()
run: |
$xmlFile = "report.xml"
$xslFile = ".github/workflows/add_final_status.xsl"
$tmpFile = [System.IO.Path]::GetTempFileName()

echo "Fixing $xmlFile"

$transform = New-Object System.Xml.Xsl.XslCompiledTransform
$transform.Load($xslFile)
$transform.Transform($xmlFile, $tmpFile)

Move-Item -Force $tmpFile $xmlFile
- name: Upload test report to Datadog
if: success() || failure()
run: |
Expand Down
Loading