-
Notifications
You must be signed in to change notification settings - Fork 16
feat(telemetry): implement app-extended-heartbeat event #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
445f045
feat(telemetry): implement app-extended-heartbeat event
khanayan123 33bede8
style: fix clang-format violations
khanayan123 d29b065
chore: regenerate supported-configurations.json
khanayan123 f42f6d8
fix(telemetry): fix task scheduling order and add test for extended h…
khanayan123 c0cab71
fix(test): use interval-based task identification in FakeEventScheduler
khanayan123 6766649
test(telemetry): verify extended heartbeat includes configuration pay…
khanayan123 efe9d01
Update include/datadog/environment.h
khanayan123 ffd6ec7
Update src/datadog/telemetry/configuration.cpp
khanayan123 c83bee7
Update include/datadog/telemetry/configuration.h
khanayan123 4c74565
Update src/datadog/telemetry/configuration.cpp
khanayan123 02c7206
fix(telemetry): use all_configurations_ for extended heartbeat payload
khanayan123 f110109
fix(telemetry): fix clang-format violations and chrono cast for doubl…
khanayan123 9ff6721
test(telemetry): verify extended heartbeat reflects runtime config ch…
khanayan123 63ee7b1
refactor(telemetry): extract serialize_configuration_field helper
khanayan123 67a4203
chore: regenerate supported-configurations.json
khanayan123 c2c27a4
test(telemetry): add env var override test for extended heartbeat int…
khanayan123 c888b84
test(telemetry): add code override and validation tests for extended …
khanayan123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should integrations too be sent? eg https://github.com/DataDog/dd-trace-cpp/pull/289/changes#diff-8e4b8c344253799b7a41954c017a79f7b026dca44849dc2dec9460120dc57a53R745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the spec, the integrations and dependencies payloads are optional:
https://github.com/DataDog/instrumentation-telemetry-api-docs/blob/main/GeneratedDocumentation/ApiDocs/v2/SchemaDocumentation/Schemas/app_extended_heartbeat.md
Since this work is focused on Config Visibility reliability and only requires the configs payload, I’m planning to scope this PR to just that.