P25 V.24/DFSI: fix startup clipping and duplicate STOP teardown#116
Closed
tsawyer wants to merge 10 commits intoDVMProject:masterfrom
Closed
P25 V.24/DFSI: fix startup clipping and duplicate STOP teardown#116tsawyer wants to merge 10 commits intoDVMProject:masterfrom
tsawyer wants to merge 10 commits intoDVMProject:masterfrom
Conversation
prevent stray network/RF TDU/TDULC from tearing down V.24 at call start
Member
|
Because we did a cherry pick I'm closing this PR (but keeping it here for documentation purposes) in favor of #117. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens P25 V.24/DFSI call handling by fixing startup queue/scheduler behavior and tightening end-of-call STOP generation.
What this fixes
Changes
m_lastP25Tx = 0) so new calls do not inherit prior timing.immflag from P25 writer to modem write path..DS_Storeignore entry to.gitignore.Validation
NAK, command = 0x...or serial write failure signatures observed in test capture window.Notes to Devs