Fix Bug/285 - allow prepared statements to be prepared multiple times#309
Open
siddharth178 wants to merge 2 commits intoDATA-DOG:masterfrom
Open
Fix Bug/285 - allow prepared statements to be prepared multiple times#309siddharth178 wants to merge 2 commits intoDATA-DOG:masterfrom
siddharth178 wants to merge 2 commits intoDATA-DOG:masterfrom
Conversation
Allow prepared statements to be prepared multiple times to support how Golang handles prepared statements. (ref: https://pkg.go.dev/database/sql#Stmt)
|
Thanks for this fix, @siddharth178! We've backported it into our maintained fork at Allowed-Online/go-sqlmock. Your work didn't go to waste. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't see need to enable/disable this, so kept it as default behaviour.