Skip to content

[skip ci] fix: batch fixes for issues #3044, 3045, 3046, 3047, 3048, 3049, 3057, 3058, 3059, 3060#400

Open
echobt wants to merge 1 commit intomasterfrom
fix/bounty-batch-3044-3060
Open

[skip ci] fix: batch fixes for issues #3044, 3045, 3046, 3047, 3048, 3049, 3057, 3058, 3059, 3060#400
echobt wants to merge 1 commit intomasterfrom
fix/bounty-batch-3044-3060

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 27, 2026

Summary

Batch fix for multiple bounty issues.

Issues Fixed

Changes

LSP Enhancements (cortex-cli/src/debug_cmd.rs)

  • Added --detect-from-editor flag to detect LSP servers from .vscode/settings.json
  • Added --short-paths flag to show command name instead of full path for PATH-accessible servers
  • Added --test flag to test LSP server functionality via initialize request
  • Added support for [lsp] config section with disabled list and custom args
  • LSP servers can now be disabled in config without uninstalling

Wait Command Enhancements

  • Added --all flag to wait for multiple conditions simultaneously
  • Can now combine --lsp-ready --server-ready --port with --all

Paths Command Improvements

  • Changed status from 'missing' to 'not created' for optional directories
  • Added explanatory note about on-demand directory creation

Install Scripts (scripts/)

  • Created install.sh with:
    • SHA256 checksum verification
    • Version format validation to prevent path traversal attacks
    • Proper error handling and user feedback
  • Created install.ps1 with:
    • SHA256 checksum verification using Get-FileHash
    • Version format validation
    • User prompt to add to PATH

Documentation

  • Added exit code documentation to debug commands (0=success, 1=error, 2=usage)

Note: CI skipped for cost control. Test manually before merge.

…, 3058, 3059, 3060 [skip ci]

Fixes:
- #3044: Add LSP Server Auto-Detection from Editor Configs
  - Added --detect-from-editor flag to cortex debug lsp
  - Parses .vscode/settings.json for configured LSP servers

- #3045: LSP Server Paths Show Redundant Full Path
  - Added --short-paths flag to show command name instead of full path
  - Added in_path field to track if command is in PATH

- #3046: Add LSP Server Functionality Testing
  - Added --test flag to cortex debug lsp
  - Sends LSP initialize request to verify server responds

- #3047: No Way to Disable Specific LSP Servers
  - Added support for lsp.disabled config option
  - Shows (disabled) status in debug lsp output

- #3048: Add LSP Server Configuration Section in Config
  - Added support for [lsp] section in config.toml
  - Supports disabled list and custom args per server

- #3049: Snapshots Directory Never Used Despite Being Listed
  - Changed status from 'missing' to 'not created' for optional dirs
  - Added note explaining directories are created on-demand

- #3057: install.ps1 Has No Checksum Verification
  - Created scripts/install.ps1 with SHA256 checksum verification
  - Uses Get-FileHash for secure download verification

- #3058: install.sh Allows Path Traversal via CORTEX_VERSION
  - Created scripts/install.sh with version format validation
  - Rejects versions containing path traversal characters (../)

- #3059: Add Support for Multiple Wait Conditions
  - Added --all flag to cortex debug wait
  - Allows combining --lsp-ready, --server-ready, --port

- #3060: Document Exit Codes for All Commands
  - Added exit code documentation to module and struct docs
  - 0=success, 1=error/condition not met, 2=usage error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant