fix: batch fixes for issues #2906, 2909, 2911, 2913, 2915, 2919, 2921, 2924, 2927, 2928 [skip ci]#395
Open
fix: batch fixes for issues #2906, 2909, 2911, 2913, 2915, 2919, 2921, 2924, 2927, 2928 [skip ci]#395
Conversation
…, 2924, 2927, 2928 [skip ci] - #2906: Add unified --mode filter flag to agent list command - #2909: Validate MCP server environment variables for dangerous patterns - #2911: Normalize file paths in debug file command to remove trailing dots - #2913: Return explicit error when --attach URL format is invalid - #2915: Add --quiet flag to login command for CI/CD scripting - #2919: Add JSON metadata output format for scrape command - #2921: Add --dry-run flag to mcp add command - #2924: Add capability filters (--vision, --tools, --json-mode) to models list - #2927: Include full error chain and OS error codes in MCP debug errors - #2928: Add agent test command for configuration validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements fixes for 10 bounty issues:
Issue Fixes
--modefilter flag tocortex agent listcommand (accepts comma-separated values likeprimary,subagent, keeps legacy--primary/--subagentsfor backwards compatibility).when runningcortex debug file ., addednormalize_path()helper function)--attachflag behavior from silent fallback to explicit error (validates URL format, provides clear error message instead of falling back to local execution)--quiet/-qflag to login command (suppresses success output, only shows errors, useful for CI/CD scripting)--dry-runflag tocortex mcp addcommand (previews configuration without making changes)--vision,--tools,--json-modeflags to filter by model capabilities)cortex agent testcommand for configuration validation (validates agent config including temperature ranges, tool references, conflicting settings, outputs errors and warnings)Files Changed
cortex-cli/src/agent_cmd.rs- Mode filter, Test commandcortex-cli/src/mcp_cmd.rs- Env var validation, dry-run, enhanced error messagescortex-cli/src/debug_cmd.rs- Path normalizationcortex-cli/src/run_cmd.rs- Attach URL validationcortex-cli/src/login.rs- Quiet flagcortex-cli/src/main.rs- Quiet flag propagationcortex-cli/src/scrape_cmd.rs- JSON metadata outputcortex-cli/src/models_cmd.rs- Capability filtersCloses #2906, #2909, #2911, #2913, #2915, #2919, #2921, #2924, #2927, #2928