[skip ci] fix: batch fixes for issues #2090, 2091, 2093, 2095, 2098, 2169, 2170, 2171, 2172, 2173#393
Open
[skip ci] fix: batch fixes for issues #2090, 2091, 2093, 2095, 2098, 2169, 2170, 2171, 2172, 2173#393
Conversation
…, 2171, 2172, 2173 [skip ci] Fixes: - #2090: Added LC_ALL/LANG locale validation with warning for invalid values - #2091: Improved upgrade --channel beta/nightly message when no versions available - #2093: Added BrokenPipe handling for upgrade --check when output is piped - #2095: Added BrokenPipe handling for --debug scrape output when piped - #2098: Already fixed (--dry-run flag already exists in run command) - #2169: Added fsync and file size verification for export to detect network filesystem issues - #2170: Already fixed (warn_if_ambiguous_model already warns about ambiguous model names) - #2171: Added config file watcher support for atomic file replacement (directory-based watching) - #2172: Added OOM kill detection for sandbox process exits (cgroup v2 support) - #2173: Sessions list now gracefully handles corrupted session files instead of failing entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch fix for multiple bounty issues.
Issues Fixed
Changes
cortex-cli/src/main.rs: Addedvalidate_locale_env()function to warn about invalid LC_ALL/LANG valuescortex-cli/src/upgrade_cmd.rs: Added better messaging for beta/nightly channels, BrokenPipe handlingcortex-cli/src/scrape_cmd.rs: Added BrokenPipe handling for piped outputcortex-cli/src/export_cmd.rs: Added fsync() and file size verification for network filesystem reliabilitycortex-app-server/src/config.rs: Added config file watcher that watches parent directory for atomic file replacementcortex-linux-sandbox/src/run_main.rs: Added OOM kill detection using cgroup v2 memory eventscortex-engine/src/session.rs: Sessions list now skips corrupted files with warnings instead of failing