Skip to content

[skip ci] fix: batch fixes for issues #1887, 1888, 1892, 1893, 1895, 1896, 1897, 1904, 1905, 1909#385

Open
echobt wants to merge 1 commit intomasterfrom
fix/bounty-batch-1887-1909
Open

[skip ci] fix: batch fixes for issues #1887, 1888, 1892, 1893, 1895, 1896, 1897, 1904, 1905, 1909#385
echobt wants to merge 1 commit intomasterfrom
fix/bounty-batch-1887-1909

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 27, 2026

Summary

Batch fix for multiple bounty issues.

Issues Fixed

Changes

  1. mcp commands: Changed name argument to Option with friendly error messages when missing
  2. debug skill: Added check for directory paths before attempting to read, with clear error message
  3. config override: Added validation for known config keys with error on unknown keys
  4. import command: Added special handling for "-" to read from stdin
  5. pr command: Made PR number optional, added auto-detection using gh CLI and friendly usage message
  6. github run: Token now checks GITHUB_TOKEN env var, allows dry-run without token
  7. subcommands: Made subcommand optional for debug, github, sandbox with helpful output when None

Pre-existing Build Fixes

  • Added missing trust_proxy field to RateLimitConfig in cortex-app-server
  • Fixed duplicate output field in run_cmd.rs (renamed to output_file)
  • Added cookies feature to reqwest dependency
  • Made install_panic_hook function public

Note: CI skipped for cost control. Test manually before merge.

…, 1904, 1905, 1909 [skip ci]

Fixes:
- #1887: mcp get/add/remove without args now shows 'Please provide a server name' instead of generic clap error
- #1888: debug skill with directory path now shows 'Path is a directory, not a file' instead of 'Is a directory' error
- #1892: -c with invalid config key now shows 'Unknown configuration key' error instead of silently ignoring
- #1893: import - now reads from stdin instead of trying to read literal file named '-'
- #1895: pr without number now attempts to detect PR for current branch using gh CLI
- #1896: github run now checks GITHUB_TOKEN env var, allows --dry-run without token for read-only ops
- #1897: pr without number now shows helpful usage message instead of clap error
- #1904: debug without subcommand now shows help and exits 0 instead of exit 2
- #1905: github without subcommand now shows help and exits 0 instead of exit 2
- #1909: sandbox without subcommand now shows help and exits 0 instead of exit 2

Also fixes pre-existing build issues:
- Added trust_proxy field to RateLimitConfig
- Fixed duplicate output field in run_cmd.rs
- Added cookies feature to reqwest
- Made install_panic_hook public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant