Move color service to core/ui#3716
Open
UrbanBobek wants to merge 3 commits intoControlSystemStudio:masterfrom
Open
Move color service to core/ui#3716UrbanBobek wants to merge 3 commits intoControlSystemStudio:masterfrom
UrbanBobek wants to merge 3 commits intoControlSystemStudio:masterfrom
Conversation
Adds WidgetColor, NamedWidgetColor, NamedWidgetColors, WidgetColorService, ConfigFileParser and FileToStreamFunction to core/ui so they can be used by any application, not just the display builder. WidgetColorService is adapted from app/display/model: the shared ModelPlugin.logger is replaced with a per-class logger following the convention used across core/ui, ModelThreadPool is replaced with CompletableFuture.supplyAsync(), and the display-model-specific read timeout preference is replaced with a 5000ms constant. ColorUnitTest and DelayedStream moved here from app/display/model, along with the color.def example file used by the tests.
WidgetColor, NamedWidgetColor, NamedWidgetColors, WidgetColorService, ConfigFileParser and FileToStreamFunction have been removed from app/display/model and all import references across app/display updated to use the new org.phoebus.ui.color package. NamedWidgetFonts, WidgetFontService and WidgetClassesService updated to directly reference org.phoebus.ui.color.ConfigFileParser and FileToStreamFunction. ColorUnitTest moved to core/ui.
Member
|
Thank you, In this PR we might want to double check the usage to the to evaluate if it justifies being moved to a core/util module instead of the core/color one. |
UrbanBobek
changed the title
…nfig These utilities are not color-specific — they are used by color, font, and widget class loading. All import references in core/ui and app/display/model updated accordingly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for this task of the Codeathon 2026
First step is to migrate the color service to
core/uiso all applications can use the colors and not just the display builder.Later, the inconsistent implementation of how colors are used across the codebase should be addressed.
Checklist
Testing:
Documentation: