London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 1 | Coursework#1090
Open
djebsoft wants to merge 19 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 1 | Coursework#1090djebsoft wants to merge 19 commits intoCodeYourFuture:mainfrom
djebsoft wants to merge 19 commits intoCodeYourFuture:mainfrom
Conversation
Updated comment to clarify the assignment operation.
Updated the initials variable to dynamically generate initials from first, middle, and last names.
Implemented logic to extract directory and extension from filePath.
Added comments to explain the purpose and behavior of the num variable and the random number generation process.
Changed 'const' to 'let' for age variable to allow reassignment.
Fix variable declaration order to avoid reference error.
Updated last4Digits assignment to convert cardNumber to a string before slicing.
Updated variable names to avoid starting with digits.
Fixed syntax error in priceAfterOneYear assignment and updated comments.
Added comments to explain the purpose of each step in the code.
This comment has been minimized.
This comment has been minimized.
djebsoft
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
djebsoft
changed the title
This comment has been minimized.
This comment has been minimized.
djebsoft
added
the
Needs Review
Updated the capitalise function to fix variable redeclaration and corrected the return variable name.
Declare 'result' with 'let' to avoid redeclaration error.
…ge function Removed duplicate declaration of decimalNumber and updated comments.
Corrected the square function to properly accept a parameter and return its square.
Refactored multiply function to include return statement and improved logging.
Fix the sum function to correctly return the sum of two numbers.
Corrected the getLastDigit function to accept a parameter and return the last digit of a number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed the mandatory sections of sprint 1 for the second module
Questions