London| SDC-Nov-2025| Ikenna Agulobi | Sprint 1 | bug/ Extra long blooms#166
Open
ike-agu wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London| SDC-Nov-2025| Ikenna Agulobi | Sprint 1 | bug/ Extra long blooms#166ike-agu wants to merge 1 commit intoCodeYourFuture:mainfrom
ike-agu wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
- Implemented length checks in endpoint with HTTP 400 responses. - Added a safety validation in to protect the database layer.
ike-agu
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
suggested changes
Feb 28, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
You need to harmonize you MAX_CHARACTERS between files
| content = request.json["content"] | ||
|
|
||
| #----Validation----- | ||
| if len(content) > 280: |
There was a problem hiding this comment.
Argh! You did so well to introduce a constant in the other file. You need to use the same constant here too!
github-project-automation
bot
moved this from Backlog
to In Progress
in Purple Forest Kanban
OracPrime
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR implements character limit enforcement for "Blooms". Also prevents oversized data from being stored in the database.
Changes:
API: Updated send_bloom in endpoint.py to validate content length and return a 400 Bad Request if the limit is exceeded.
Backend: Added a ValueError check in blooms.py as a secondary safety measure.
How to Test:
Verify the server returns a 400 error with the message: "Bloom is too long! Max 280 characters."