Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | Extra long blooms#156
Open
katarzynakaz wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | Extra long blooms#156katarzynakaz wants to merge 2 commits intoCodeYourFuture:mainfrom
katarzynakaz wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
katarzynakaz
added
📅 Sprint 1
OracPrime
added
the
Review in progress
OracPrime
suggested changes
Feb 28, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
The code for the actual change asked for is fine. However you've polluted the PR with a whole load of other changes. This would not be accepted in a professional environment
| # return hashlib.scrypt(password_plaintext, salt=password_salt, n=8, r=8, p=1) | ||
| def scrypt(password_plaintext: bytes, password_salt: bytes) -> bytes: | ||
| return hashlib.scrypt(password_plaintext, salt=password_salt, n=8, r=8, p=1) | ||
| return hashlib.pbkdf2_hmac('sha256', password_plaintext, password_salt, 100000) |
| // .querySelector("[data-action='login']") | ||
| // ?.addEventListener("click", handleLogin); | ||
| .querySelector(".login__form") | ||
| ?.addEventListener("submit", handleLogin); |
There was a problem hiding this comment.
Isn't this a change from a different backlog item? Shouldn't be here.
github-project-automation
bot
moved this from Backlog
to In Progress
in Purple Forest Kanban
OracPrime
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Changes the length of chars.