Skip to content

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | login bug#155

Open
katarzynakaz wants to merge 1 commit intoCodeYourFuture:mainfrom
katarzynakaz:cant-log-in-from-profile-page
Open

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | login bug#155
katarzynakaz wants to merge 1 commit intoCodeYourFuture:mainfrom
katarzynakaz:cant-log-in-from-profile-page

Conversation

@katarzynakaz
Copy link

  • [ x I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Can't log in bug fixed.

@katarzynakaz katarzynakaz added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 21, 2026
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 28, 2026
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from the commented out obsolete code

createLogin
);
document
// .querySelector("[data-action='login']")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't leave obsolete code commented out in commits

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants