generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 255
London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 1 | coursework/sprint 1 #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fayaz551
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
fayaz551:coursework/Sprint-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cbd8d1b
fixed the implementation of median.js of sprint-1
fayaz551 d7200c9
wrote the function for dedupe and wrote test cases for it to pass the…
fayaz551 0c123a4
wrote the implemention and test cases for max.js in sprint-1
fayaz551 7716249
wrote implemention for sum function to add integers and wrote multipl…
fayaz551 58dc04d
refactored the implemention of included to use for of loop instead of…
fayaz551 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,14 @@ | ||
| function dedupe() {} | ||
| function dedupe(arr) { | ||
| if (!Array.isArray(arr)) return null; | ||
|
|
||
| const seen = []; | ||
|
|
||
| for (const item of arr) { | ||
| if (!seen.includes(item)) { | ||
| seen.push(item); | ||
| } | ||
| } | ||
|
|
||
| return seen; | ||
| } | ||
| module.exports = dedupe; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,26 @@ | ||
| function findMax(elements) { | ||
| if (!Array.isArray(elements)) { | ||
| return null; | ||
| } | ||
|
|
||
| // If the array is truly empty, return -Infinity | ||
| if (elements.length === 0) { | ||
| return -Infinity; | ||
| } | ||
|
|
||
| // Filter only numeric values | ||
| const numbers = elements.filter(function (item) { | ||
| return typeof item === "number" && !isNaN(item); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. read about isFinite, and implement it here. |
||
| }); | ||
|
|
||
| // If there are no numeric values but the array wasn't empty, return null | ||
| if (numbers.length === 0) { | ||
| return null; | ||
| } | ||
|
|
||
| // Otherwise, return the largest number | ||
| return Math.max.apply(null, numbers); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works, but ES6 is more readable. Read about rest and spread, and update this line of your code. |
||
| } | ||
|
|
||
| module.exports = findMax; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,22 @@ | ||
| function sum(elements) { | ||
| if (!Array.isArray(elements)) { | ||
| return 0; | ||
| } | ||
|
|
||
| // Filter only numeric values | ||
| const numbers = elements.filter(function (item) { | ||
| return typeof item === "number" && !isNaN(item); | ||
| }); | ||
|
|
||
| // If no numeric values, return 0 | ||
| if (numbers.length === 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| // Add the numbers | ||
| return numbers.reduce(function (total, value) { | ||
| return total + value; | ||
| }, 0); | ||
| } | ||
|
|
||
| module.exports = sum; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Number.isFinite(item)
Read about isFinite method. It is a btter way to check.