Manchester|25-SDC-NOV| Rahwa Haile | Sprint 1|Analyse and refactor#109
Open
RahwaZeslusHaile wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Manchester|25-SDC-NOV| Rahwa Haile | Sprint 1|Analyse and refactor#109RahwaZeslusHaile wants to merge 5 commits intoCodeYourFuture:mainfrom
RahwaZeslusHaile wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
…) time, O(n) space using Set
…based implementation
RahwaZeslusHaile
added
the
Needs Review
SlideGauge
reviewed
Mar 1, 2026
There was a problem hiding this comment.
Looks like this file is not needed here
| if (numbers[i] + numbers[j] === target) { | ||
| return true; | ||
| } | ||
| const seen = new Set(); |
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity: O(n) |
There was a problem hiding this comment.
Initial time complexity is worse than O(n)
SlideGauge
added
Reviewed
|
Also, as far as I see you wrote JS only here. Are you going to include python tasks in the same PR or do the separate one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester|25-SDC-NOV| Rahwa Haile | Sprint 1|Analyse and refactor## Learners, PR Template
Self checklist
Changelist
This PR includes several improvements and optimizations to utility functions:
findCommonItems
Optimized from O(n × m) to O(n + m) using Set.
Avoids duplicates and improves performance for large arrays.
hasPairWithSum
Added function to check if any two numbers sum to a target.
Brute-force version O(n²), later optimized to O(n) with a Set.
removeDuplicates
Refactored from nested loops (O(n²)) to a Set-based solution (O(n) time, O(n) space).
Preserves original order while removing duplicates.
calculateSumAndProduct
Combined sum and product calculation into a single loop (O(n) time, O(1) space).
Cleaned up code for readability and efficiency.
All functions are tested and ready to use.
Questions
I would really appreciate your feedback. Thank you for reviewing my submission!