West Midlands | SDC-25 | Gabriel Deng | Sprint 2 | Implement a linked list in Python #100
Open
gai93003 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
West Midlands | SDC-25 | Gabriel Deng | Sprint 2 | Implement a linked list in Python #100gai93003 wants to merge 2 commits intoCodeYourFuture:mainfrom
gai93003 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
gai93003
added
Needs Review
cjyuan
reviewed
Feb 27, 2026
| @@ -0,0 +1,60 @@ | |||
| class Node: | |||
| __slots__ = ("value", "previous", "next") | |||
Comment on lines
34
to
39
| if node.previous is None: | ||
| # One element | ||
| self.head = self.tail = None | ||
| else: | ||
| self.tail = node.previous | ||
| self.tail.next = None |
There was a problem hiding this comment.
Could also just call remove(node) -- less code to maintain.
Author
There was a problem hiding this comment.
I have removed the duplicate logic. Thanks.
Comment on lines
+59
to
+60
| node.previous = None | ||
| node.next = None No newline at end of file |
There was a problem hiding this comment.
Why not also clean up references in pop_tail()?
cjyuan
added
Reviewed
|
Change label? |
Author
I can change the label if you think the solution looks good enough😊 |
|
Can you look up how labels are used in the CodeYourFuture review flow? I expect it is the same as ITP. |
Author
|
I think I have added all the labels except the complete label. I am not sure If I missed something |
Author
|
Oh yeah, I get it now. Thanks. I will add the needs review label |
gai93003
added
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist