Fix HTML-escaped tool-call args and preserve upstream token usage (stream & non-stream)#239
Merged
CJackHwang merged 2 commits intodevfrom Apr 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77a401fb19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Apr 7, 2026
Merge pull request #239 from CJackHwang/codex/fix-escaping-issues-and-token-counting Fix HTML-escaped tool-call args and preserve upstream token usage (stream & non-stream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
>) which caused command execution deviations when parsed as tool arguments.input_tokens/output_tokensor string-valued numbers, causing third-party clients (e.g. Vercel deployments) to show inaccurate token counts when the translator fell back to estimated values.Description
html.UnescapeStringtoNameand recursively toInputvalues ininternal/toolcall/toolcalls_parse.goso arguments like>become>again.internal/translatorcliproxy/stream_writer.gosoextractOpenAIUsagealso considersinput_tokens/output_tokensand accepts string-encoded numeric fields by updatingtoIntto parsestringviastrconv.Atoi.extractOpenAIUsageFromJSONandinjectNonStreamUsageMetadataininternal/translatorcliproxy/bridge.goand applying usage metadata into converted responses forClaude(usage.input_tokens/output_tokens) andGemini(usageMetadata) so translated non-stream responses carry the original token counts.TestParseToolCallsUnescapesHTMLEntityArgumentsininternal/toolcall/toolcalls_test.go,TestExtractOpenAIUsageSupportsResponsesUsageFieldsininternal/translatorcliproxy/stream_writer_test.go, andTestFromOpenAINonStreamPreservesResponsesUsageShapeininternal/translatorcliproxy/bridge_test.go.Testing
go test ./internal/translatorcliproxy ./internal/toolcalland both packages passed (ok ds2api/internal/translatorcliproxyandok ds2api/internal/toolcall).Codex Task