Skip to content

fix translations strings#426

Open
Alessandro-Barbieri wants to merge 25 commits intoBreakBB:masterfrom
Alessandro-Barbieri:lowercase
Open

fix translations strings#426
Alessandro-Barbieri wants to merge 25 commits intoBreakBB:masterfrom
Alessandro-Barbieri:lowercase

Conversation

@Alessandro-Barbieri
Copy link
Contributor

No description provided.

@Alessandro-Barbieri
Copy link
Contributor Author

do you prefer a huge migration or a profile reset?

@Alessandro-Barbieri
Copy link
Contributor Author

I opted for the profile reset because the migration looked ridiculously long

type = "toggle",
order = 0,
name = function() return i18n("Show Defense Stats") end,
name = function() return i18n("Show defense stats") end,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think stat names should be lower case. So I'd prefer "Defense" over "defense" and "Mana" over "mana" and "Shadow Damage" over "Shadow damage".

The default UI is also using capitalized words like "Crit Chance".

I am okay with using "stats" and "values". For me "Hit Rating" is also a stat name, so I don't think it should be lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many consistency issues right now:

  • majority of phrases that start with "Show" are in lowercase except in german
  • stats names (without a sentence attached) are capitalized only in english and german

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do expect inconsistencies when comparing different languages. I personally can only check on correctness on English and German. And for both stat names should be capitalized.

If a translation does not follow the rules of the Blizzard UI or their basic grammatical rules that is a) something up to fix for a native speaker and b) not really a big issue.

Not sure what languages you can assess, but feel free to update the translations for these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent with blizzard globalstrings

ITEM_MOD_CRIT_SPELL_RATING = "Improves spell critical strike rating by %s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Critical Strike (Spell)";
ITEM_MOD_CRIT_SPELL_RATING = "Mejora el índice de golpe crítico con hechizos en %s p.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Golpe crítico (hechizo)";
ITEM_MOD_CRIT_SPELL_RATING = "Augmente de %s le score de coup critique des sorts.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Score de critique (sorts)";
ITEM_MOD_CRIT_SPELL_RATING = "Erhöht die kritische Zaubertrefferwertung um %s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "Kritischer Trefferwert (Zauber)";
ITEM_MOD_CRIT_SPELL_RATING = "Критический удар (заклинания) +%s.";
ITEM_MOD_CRIT_SPELL_RATING_SHORT = "к критическому эффекту заклинаний";

I put sentences lowercase, the rest uppercase (English only)
German is all uppercase, the other languages lowercase
I also added full stops at the end of sentences and abbreviations

@Alessandro-Barbieri Alessandro-Barbieri changed the title lowercase all the strings fix translations strings Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants