Add OperatorInfo message to track dive operator#254
Conversation
Introduce a new OperatorInfo message (name, email) in message_formats.proto to identify the operator controlling the drone. Add it as an optional field on StartDiveCtrl so dive logs capture who started each dive, enabling reporting and Blueye Cloud import workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds operator attribution to the control/logging protocol by introducing an OperatorInfo message and attaching it to StartDiveCtrl, enabling dive logs (and downstream imports) to record who initiated a dive.
Changes:
- Added new
OperatorInfoproto message withnameandemail. - Extended
StartDiveCtrlwith anoperatorfield carryingOperatorInfo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| protobuf_definitions/message_formats.proto | Introduces OperatorInfo shared message for identifying a dive operator. |
| protobuf_definitions/control.proto | Adds operator metadata to StartDiveCtrl for inclusion in logs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lict `operator` is a reserved keyword in C++ and C#, which would mangle generated accessors. Renamed to `operator_info` while the field is new. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aviggen
left a comment
There was a problem hiding this comment.
How would the user pick the operator? Is it only when the user is logged in in the app?
|
We can choose. It would be two string settings stored locally, that the user can set: Default Operator Name, and Default Operator Email. After Blueye Cloud, we will get it from the signed in user. This will solve the case where say Trond does dives with a drone, and someone else synchronizes it, then in the Blueye Cloud, we can assign the operator automatically during ingestion. |
Summary
OperatorInfomessage inmessage_formats.protowithnameandemailfields to identify the operator controlling the drone.operatorfield toStartDiveCtrlincontrol.proto, so dive logs capture who started each dive.Test plan
🤖 Generated with Claude Code