feat(wasm-dot): change encodeSs58/validateAddress to accept number#205
Closed
bitgo-ai-agent-dev[bot] wants to merge 1 commit intomasterfrom
Closed
feat(wasm-dot): change encodeSs58/validateAddress to accept number#205bitgo-ai-agent-dev[bot] wants to merge 1 commit intomasterfrom
bitgo-ai-agent-dev[bot] wants to merge 1 commit intomasterfrom
Conversation
Parameter type changed from AddressFormat (0|2|42 union) to number, so callers can pass any numeric SS58 prefix without a cast. Existing callers using AddressFormat.Polkadot etc. continue to work unchanged. Ticket: T1-57 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the parameter type of
encodeSs58andvalidateAddressinaddress.tsfromAddressFormat(0 | 2 | 42) tonumber.Why
PR #203 changed
AddressFormatfrom a TypeScript enum to a union type (0 | 2 | 42), but left the wrapper function signatures asformat: AddressFormat. This means callers passing a numeric enum likeDotAddressFormatfromsdk-corestill get a type error — numeric enum values widen tonumber, which is not assignable to0 | 2 | 42.Changing the parameter to
numberfixes this. TheAddressFormatconstants (AddressFormat.Polkadotetc.) remain usable at call sites since their literal types (0,2,42) are assignable tonumber.Existing callers
No changes needed anywhere.
AddressFormat.Polkadot(type0) is assignable tonumber. Callers in bgms can droptoWasmAddressFormatand passDotAddressFormatdirectly once this publishes.Ticket: T1-57
🤖 Generated with Claude Code