Skip to content

feat: 환경 변수 더미데이터 설정 추가#2176

Merged
Soundbar91 merged 1 commit intodevelopfrom
fix/cd-workflows
Mar 13, 2026
Merged

feat: 환경 변수 더미데이터 설정 추가#2176
Soundbar91 merged 1 commit intodevelopfrom
fix/cd-workflows

Conversation

@Soundbar91
Copy link
Collaborator

@Soundbar91 Soundbar91 commented Mar 13, 2026

🔍 개요

  • close #이슈번호

🚀 주요 변경 내용


💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • Chores
    • Updated CI/CD build pipeline to properly export and configure environment variables from configuration files
    • Enhanced build process with environment-specific Spring profiles for development and production deployments
    • Switched to clean builds and removed caching to ensure consistent, reproducible builds across environments

@Soundbar91 Soundbar91 self-assigned this Mar 13, 2026
@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Mar 13, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

📝 Walkthrough

Walkthrough

This PR modifies GitHub Actions CI/CD workflows for backend builds. The Build JAR steps now source environment variables from .env.example before running Gradle clean builds with explicit Spring profiles (dev/prod), while removing the build-cache flag.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/backend-cd-develop.yml, .github/workflows/backend-cd-main.yml
Modified Build JAR step to source environment variables from .env.example before running Gradle clean builds with Spring profiles (dev for develop, prod for main), and removed the --build-cache flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

인프라

Suggested reviewers

  • ff1451

Poem

🐰 A workflow clean and bright,
Env variables sourced just right,
Build cache farewell, profiles set free,
Develop and main flow in harmony! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title refers to adding environment variable dummy data configuration, but the actual changes involve modifying CI/CD workflows to export environment variables and set Spring profiles for dev/prod builds. Update the title to reflect the actual changes: modify it to something like 'feat: update CI/CD workflows to source environment variables and configure Spring profiles' to accurately represent the workflow modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cd-workflows
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@ff1451 ff1451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/backend-cd-develop.yml (1)

43-47: Add explicit shell: bash and strict flags for safer CI execution.

Line 45 uses source (a Bash builtin), but this step relies on the default shell behavior. While ubuntu-latest defaults to Bash, explicitly setting shell: bash is a best practice for consistency across runners and environments. Additionally, adding strict shell flags prevents silent failures.

Suggested patch
       - name: Build JAR
+        shell: bash
         run: |
+          set -euo pipefail
           set -a
           source .env.example
           set +a
           ./gradlew clean build -x test -Dspring.profiles.active=dev
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/backend-cd-develop.yml around lines 43 - 47, This CI step
uses the Bash builtin source and should be made explicit and strict: add shell:
bash to the step and change the run script to enable strict flags (e.g., start
with set -euo pipefail and optionally IFS=$'\n\t'), then export env file as
before (set -a; source .env.example; set +a) and run the existing Gradle command
(./gradlew clean build -x test -Dspring.profiles.active=dev); refer to the lines
containing source .env.example and ./gradlew clean build -x test
-Dspring.profiles.active=dev when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/backend-cd-develop.yml:
- Around line 43-47: This CI step uses the Bash builtin source and should be
made explicit and strict: add shell: bash to the step and change the run script
to enable strict flags (e.g., start with set -euo pipefail and optionally
IFS=$'\n\t'), then export env file as before (set -a; source .env.example; set
+a) and run the existing Gradle command (./gradlew clean build -x test
-Dspring.profiles.active=dev); refer to the lines containing source .env.example
and ./gradlew clean build -x test -Dspring.profiles.active=dev when making the
change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc88f00c-6dd0-467d-96b6-c50812326444

📥 Commits

Reviewing files that changed from the base of the PR and between dda0d2e and 34c0067.

📒 Files selected for processing (2)
  • .github/workflows/backend-cd-develop.yml
  • .github/workflows/backend-cd-main.yml

@github-actions
Copy link

Unit Test Results

690 tests   687 ✔️  1m 26s ⏱️
169 suites      3 💤
169 files        0

Results for commit 34c0067.

@Soundbar91 Soundbar91 merged commit fc813fd into develop Mar 13, 2026
9 checks passed
@Soundbar91 Soundbar91 deleted the fix/cd-workflows branch March 13, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants