HotChocolate 16 Milestone 11 Migration#3136
Conversation
michaelstaib
requested review from
Alekhya-Polavarapu,
Aniruddh25,
RubenCerna2079,
aaronburtle,
anushakolan,
neeraj-sharma2592,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
| DATETIME_TYPE => new(DATETIME_TYPE, new DateTimeType().ValueToLiteral( | ||
| DateTime.Parse(defaultValueFromConfig, DateTimeFormatInfo.InvariantInfo, DateTimeStyles.AssumeUniversal))), | ||
| BYTEARRAY_TYPE => new(BYTEARRAY_TYPE, new ByteArrayType().ParseValue(Convert.FromBase64String(defaultValueFromConfig))), | ||
| LOCALTIME_TYPE => new(LOCALTIME_TYPE, new HotChocolate.Types.NodaTime.LocalTimeType().ParseResult(LocalTimePattern.ExtendedIso.Parse(defaultValueFromConfig).Value)), |
There was a problem hiding this comment.
Do both ParseResult and ParseValue map to ValueToLiteral now?
There was a problem hiding this comment.
Oh ... overlooked this one...
Its mainly naming ... the reference implementation created a better naming for scalar the conversion tasks as scalar has. We adopted this change to Hot Chocolate.
I will however look at this change more closely.
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
@copilot, fix formatting error: /home/vsts/work/1/s/src/Core/Services/ExecutionHelper.cs(21,1): warning IDE0005: Using directive is unnecessary. [/home/vsts/work/1/s/src/Core/Azure.DataApiBuilder.Core.csproj] |
looks like copilot wont work cross repos, this needs to be fixed manually. |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
3 participants
Why make this change?
This upgraded Data API Builder to the near final preview of Hot Chocolate 16