[MSI] Regenerate SDK from TypeSpec#48767
Open
weidongxu-microsoft wants to merge 2 commits intoAzure:mainfrom
Open
[MSI] Regenerate SDK from TypeSpec#48767weidongxu-microsoft wants to merge 2 commits intoAzure:mainfrom
weidongxu-microsoft wants to merge 2 commits intoAzure:mainfrom
Conversation
- Updated module-info.java to open implementation.models to azure.core - Added revapi suppressions for ListResult class removals, OperationDisplay constructor/setter changes - New models: AssignmentRestrictions, ClaimsMatchingExpression, SystemAssignedIdentityProperties Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
the
Mgmt
weidongxu-microsoft
requested review from
a team,
JonathanGiles,
Netyyyy,
alzimmermsft,
haolingdong-msft,
moarychan,
rujche,
saragluna and
srnagar
as code owners
weidongxu-microsoft
requested review from
ArthurMa1978 and
XiaofeiCao
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Regenerates the azure-resourcemanager-msi management library from TypeSpec (spec PR azure-rest-api-specs#42260), updating generated clients/models to the new API surface and adding Revapi suppressions to handle the resulting breaking API deltas.
Changes:
- Regenerated MSI service clients/models for
2025-05-31-preview, including new models (AssignmentRestrictions,ClaimsMatchingExpression) and new properties on identity-related types. - Moved pageable “ListResult” models into
implementation.modelsand updated module openness/reflection metadata accordingly. - Updated generated samples, README version, assets tag, and added Revapi suppressions for expected breaking changes from the regeneration.
Reviewed changes
Copilot reviewed 36 out of 48 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/msi/azure-resourcemanager-msi/tsp-location.yaml | Adds TypeSpec source location metadata for regeneration traceability. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesUpdateSamples.java | New generated sample for updating user-assigned identities with new properties. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesListSamples.java | New generated sample for listing identities at subscription scope. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesListByResourceGroupSamples.java | New generated sample for listing identities in a resource group. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesGetByResourceGroupSamples.java | New generated sample for getting an identity by RG/name. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesDeleteSamples.java | New generated sample for deleting an identity. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/UserAssignedIdentitiesCreateOrUpdateSamples.java | New generated sample for create/update identity. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/SystemAssignedIdentitiesGetByScopeSamples.java | New generated sample for system-assigned identity get-by-scope. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/OperationsListSamples.java | New generated sample for listing provider operations. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsListSamples.java | New generated sample for listing federated identity credentials. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsGetSamples.java | New generated sample for getting federated identity credentials. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsDeleteSamples.java | New generated sample for deleting federated identity credentials. |
| sdk/msi/azure-resourcemanager-msi/src/samples/java/com/azure/resourcemanager/msi/generated/FederatedIdentityCredentialsCreateOrUpdateSamples.java | New generated sample demonstrating subject vs claims matching expression. |
| sdk/msi/azure-resourcemanager-msi/src/main/resources/META-INF/azure-resourcemanager-msi_metadata.json | Updates generated-file manifest and API version metadata. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/module-info.java | Opens implementation.models to com.azure.core for serialization/reflection. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/package-info.java | Updates package documentation to TypeSpec-generated naming. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/package-info.java | Updates models package documentation to TypeSpec-generated naming. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/OperationDisplay.java | Migrates to immutable output-only model (removes setters/ctor), updates docs. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/IsolationScope.java | Regenerated enum header for TypeSpec output. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/IdentityUpdate.java | Adds assignment restrictions support and serializes properties. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/ClaimsMatchingExpression.java | Adds new model used by flexible federated identity credentials. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/AssignmentRestrictions.java | Adds new model for restricting identity assignment providers/types. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/UserAssignedIdentitiesClientImpl.java | Regenerated REST proxy + client methods, including get/delete/list ordering and content-type headers. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/SystemAssignedIdentitiesClientImpl.java | Regenerated get-by-scope API and updated parameter ordering/docs. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/OperationsClientImpl.java | Regenerated operations list client to use implementation pageable result model. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/models/UserAssignedIdentitiesListResult.java | Moves pageable list model to implementation package and makes it immutable/output-only. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/models/OperationListResult.java | Moves pageable list model to implementation package and makes it immutable/output-only. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/models/FederatedIdentityCredentialsListResult.java | Moves pageable list model to implementation package and makes it immutable/output-only. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientImpl.java | Updates service client construction, API version, and docstrings per regenerated output. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientBuilder.java | Updates builder parameter docs/order for endpoint/subscription. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/implementation/FederatedIdentityCredentialsClientImpl.java | Regenerated federated identity credential get/delete/list surfaces and paging models. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/UserAssignedIdentitiesClient.java | Regenerated fluent interface signatures for get/delete/list and response overloads. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/SystemAssignedIdentitiesClient.java | Updates scope parameter documentation for regenerated API. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/package-info.java | Updates fluent package documentation to “Msi” naming. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/OperationsClient.java | Updates operation-list docs per regenerated API. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/UserAssignedIdentityProperties.java | Adds assignmentRestrictions to inner properties and JSON handling. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/SystemAssignedIdentityProperties.java | Makes output-only ctor private per immutable model generation. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/SystemAssignedIdentityInner.java | Migrates to immutable output-only shape and updates validation/JSON ordering. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/package-info.java | Updates fluent models package documentation to “Msi” naming. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/OperationInner.java | Migrates to immutable output-only model and updates docs. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/IdentityInner.java | Adds assignmentRestrictions and serializes properties. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/FederatedIdentityCredentialProperties.java | Adds claims matching expression support and adjusts required-field validation. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/models/FederatedIdentityCredentialInner.java | Adds claims matching expression passthrough API. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/ManagedServiceIdentityClient.java | Regenerated fluent top-level client interface ordering/docs. |
| sdk/msi/azure-resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/fluent/FederatedIdentityCredentialsClient.java | Regenerated fluent interface to include get/delete/list surfaces. |
| sdk/msi/azure-resourcemanager-msi/README.md | Updates dependency version to 2.54.0-beta.1. |
| sdk/msi/azure-resourcemanager-msi/assets.json | Updates assets tag reference for new generated output. |
| eng/lintingconfigs/revapi/track2/revapi.json | Adds Revapi suppressions for breaking changes introduced by TypeSpec regeneration. |
...resourcemanager-msi/src/main/java/com/azure/resourcemanager/msi/models/OperationDisplay.java
Show resolved
Hide resolved
.../java/com/azure/resourcemanager/msi/fluent/models/FederatedIdentityCredentialProperties.java
Show resolved
Hide resolved
...ger-msi/src/main/java/com/azure/resourcemanager/msi/fluent/ManagedServiceIdentityClient.java
Show resolved
Hide resolved
...n/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientBuilder.java
Show resolved
Hide resolved
...main/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientImpl.java
Show resolved
Hide resolved
...main/java/com/azure/resourcemanager/msi/implementation/ManagedServiceIdentityClientImpl.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate MSI SDK from TypeSpec with revapi suppressions.
Spec PR: Azure/azure-rest-api-specs#42260
Changes: