Add vnext emulator stages back to public CI pipeline#48737
Open
mbhaskar wants to merge 1 commit intoAzure:mainfrom
Open
Add vnext emulator stages back to public CI pipeline#48737mbhaskar wants to merge 1 commit intoAzure:mainfrom
mbhaskar wants to merge 1 commit intoAzure:mainfrom
Conversation
Remove the internal-only guard ({{ if eq(variables['System.TeamProject'], 'internal') }})
from the VNext emulator test stages in cosmos-sdk-client.yml so they run
on both public and internal CI pipelines.
The Skip.VnextEmulator variable condition is preserved for opt-out.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cosmos SDK client CI stage template to run the VNext Cosmos DB emulator test stages in both public and internal Azure DevOps projects by removing the internal-only template guard, while keeping the Skip.VnextEmulator opt-out condition.
Changes:
- Removed the
System.TeamProject == internaltemplate guard around the VNext emulator stages so they run in public CI. - Kept the existing
Skip.VnextEmulatorruntime condition to allow skipping these stages when needed.
Comment on lines
+160
to
+164
| - ${{ each mode in parameters.VnextEmulatorModes }}: | ||
| - stage: | ||
| displayName: Test VNext Emulator with ${{ mode }} | ||
| dependsOn: [ ] | ||
| condition: and(succeeded(), ne(variables['Skip.VnextEmulator'], 'true')) |
There was a problem hiding this comment.
PR description still contains the template placeholder text (e.g., "Please add an informative description...") and doesn’t document the motivation/linked issue(s) or how to verify. Please replace it with a concrete summary, relevant issue links, and validation steps (e.g., which pipeline run(s) confirm VNext emulator stages now execute in public CI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since VNext emulator is now used by customers, and some recent changes caused issues on vnext emulator, it is important to have vNext emulator on CI
This PR removes the internal-only guard ({{ if eq(variables['System.TeamProject'], 'internal') }}) from the VNext emulator test stages in cosmos-sdk-client.yml so they run on both public and internal CI pipelines.
The Skip.VnextEmulator variable condition is preserved for opt-out.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
CI on this PR has vNext emulator jobs