[ACR] az acr config content-trust: Begin deprecation of Docker Content Trust feature#33174
[ACR] az acr config content-trust: Begin deprecation of Docker Content Trust feature#33174
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR prepares the ACR Azure CLI module for Docker Content Trust (DCT) retirement by removing Notary client health checks and beginning deprecation of az acr config content-trust commands, including restricting content-trust update to only allow disabling.
Changes:
- Remove Notary client/version validation from
az acr check-healthand delete related Notary helper/error definitions. - Deprecate
az acr config content-trustcommand group and adjustcontent-trust updateto reject--status enabledand require confirmation when disabling. - Update tests/recordings to reflect the new
content-trustbehavior.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acr/check_health.py | Removes Notary version check from health diagnostics. |
| src/azure-cli/azure/cli/command_modules/acr/notary.py | Deletes the Notary CLI detection helper. |
| src/azure-cli/azure/cli/command_modules/acr/_errors.py | Removes Notary-related error definitions. |
| src/azure-cli/azure/cli/command_modules/acr/commands.py | Adds deprecation info to acr config content-trust command group. |
| src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py | Removes logic breaking-change announcements now that the behavior has changed. |
| src/azure-cli/azure/cli/command_modules/acr/_params.py | Restricts acr config content-trust update --status to only allow disabled. |
| src/azure-cli/azure/cli/command_modules/acr/policy.py | Adds confirmation prompt (and yes support) when disabling content trust. |
| src/azure-cli/azure/cli/command_modules/acr/_help.py | Marks content-trust help sections as to-be-deprecated. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands.py | Updates scenario test to assert enabled is rejected and disabled works with --yes. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_with_managed_registry.yaml | Updates VCR recording for the modified command behavior (but needs fixes). |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acr/_help.py:123
- The help example still uses
--status Enabled, butacr config content-trust updateno longer acceptsenabled(onlydisabled). Please update the example (and any related wording) so users don’t copy/paste an invalid value.
short-summary: Update content-trust policy for an Azure Container Registry.
examples:
- name: Update content-trust policy for an Azure Container Registry
text: >
az acr config content-trust update -r myregistry --status Enabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
az acr check-healthaz acr config content-trustaz acr config content-trust showaz acr config content-trust updateDescription
This is the follow-up PR to #32462
Azure Container Registry will retire Docker Content Trust on March 31, 2028. For more details, refer to https://aka.ms/acr/dctdeprecation.
To prepare for this deprecation, the following changes have been made in this PR:
az acr check-health, as the feature is being deprecated.az acr config content-trustaz acr config content-trust showaz acr config content-trust updateaz acr config content-trust updateto no longer accept theenabledstatus value.az acr config content-trust update -r myregistry --status disabled, the CLI will:Testing Guide
History Notes
[ACR] BREAKING CHANGE:
az acr config content-trust updateno longer accepts theenabledstatus.[ACR] BREAKING CHANGE:
az acr check-health: Removed Notary client check due to Docker Content Trust deprecation.[ACR]
az acr config content-trust,show,update: Added deprecation labels and notices.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.