Skip to content

[ACR] az acr replication create/update: Remove --region-endpoint-enabled flag#33173

Open
lizMSFT wants to merge 2 commits intoAzure:devfrom
lizMSFT:zoeyli/acr/remove_deprecated_flag
Open

[ACR] az acr replication create/update: Remove --region-endpoint-enabled flag#33173
lizMSFT wants to merge 2 commits intoAzure:devfrom
lizMSFT:zoeyli/acr/remove_deprecated_flag

Conversation

@lizMSFT
Copy link
Copy Markdown
Member

@lizMSFT lizMSFT commented Apr 10, 2026

Related command
az acr replication create
az acr replication update

Description
This is the follow-up PR to #32954 which introduced --global-endpoint-routing and deprecated --region-endpoint-enabled.

This PR completes the breaking change by removing the deprecated --region-endpoint-enabled flag.

Testing Guide
image

History Notes
[ACR] BREAKING CHANGE: az acr replication create/update: Remove deprecated --region-endpoint-enabled flag. Use --global-endpoint-routing instead.


This checklist is used to make sure that common guidelines for a pull request are followed.

@lizMSFT lizMSFT requested review from NoriZC and yanzhudd as code owners April 10, 2026 21:52
Copilot AI review requested due to automatic review settings April 10, 2026 21:52
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 10, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated --region-endpoint-enabled flag from az acr replication create/update, completing the rename to the clearer --global-endpoint-routing option in the ACR command module.

Changes:

  • Update ACR replication create/update implementation to only accept global_endpoint_routing and map it to the SDK’s region_endpoint_enabled property.
  • Remove the region_endpoint_enabled CLI argument definition and its associated linter exclusions.
  • Update ACR replication scenario tests to use --global-endpoint-routing.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands.py Updates scenario tests to use --global-endpoint-routing instead of the removed flag.
src/azure-cli/azure/cli/command_modules/acr/replication.py Removes deprecated parameter plumbing and uses global_endpoint_routing to set region_endpoint_enabled.
src/azure-cli/azure/cli/command_modules/acr/_params.py Removes the region_endpoint_enabled argument and keeps global_endpoint_routing as the sole flag.
linter_exclusions.yml Removes linter exclusions for the deleted parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants