Skip to content

[App Service] Skip symlinks in file processing #33145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielw5 wants to merge 2 commits into
base: dev
Choose a base branch
from
+5 −0
Open

[App Service] Skip symlinks in file processing #33145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f3d48
Skip symbolic links
danielw5 Apr 7, 2026
dff1dcd
Merge pull request #1 from danielw5/symlink-patch
danielw5 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/_create_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ def zip_contents_from_dir(dirPath, lang):

for filename in files:
absname = os.path.abspath(os.path.join(dirname, filename))

if os.path.islink(absname):
logger.warning("Skipping symbolic link: %s", absname)
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is being skipped intentionally, but it's logged at WARNING level. In the same function, other intentionally skipped content (e.g., .env) is logged at INFO; consider using INFO (or DEBUG) here as well to avoid alarming/noisy warnings during normal deployments.

Suggested change
logger.warning("Skipping symbolic link: %s", absname)
logger.info("Skipping symbolic link: %s", absname)

Copilot uses AI. Check for mistakes.
continue

Comment on lines +70 to +74
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 70 and 74 are blank but contain indentation whitespace. Please remove trailing whitespace on blank lines to avoid lint/style failures and unnecessary diff noise.

Suggested change
if os.path.islink(absname):
logger.warning("Skipping symbolic link: %s", absname)
continue
if os.path.islink(absname):
logger.warning("Skipping symbolic link: %s", absname)
continue

Copilot uses AI. Check for mistakes.
arcname = absname[len(abs_src) + 1:]
zf.write(absname, arcname)
Comment on lines +71 to 76
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new symlink-skipping behavior is user-visible for webapp up packaging (symlinked files will no longer be included). Please add/adjust a test to cover this case (e.g., create a temp dir with a symlink and assert it is excluded from the produced zip) to prevent regressions across platforms.

Copilot uses AI. Check for mistakes.

Expand Down
Loading