Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @prnutala, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
There was a problem hiding this comment.
Pull request overview
Updates the Azure CLI extensions index to publish a new arcdata extension version (1.5.30) by adding the corresponding wheel metadata entry.
Changes:
- Add a new
arcdata1.5.30 entry (download URL, metadata, digest) ahead of 1.5.29 in the extension index.
| { | ||
| "downloadUrl": "https://azurearcdatacli.z13.web.core.windows.net/arcdata-1.5.30-py2.py3-none-any.whl", | ||
| "filename": "arcdata-1.5.30-py2.py3-none-any.whl", | ||
| "metadata": { |
There was a problem hiding this comment.
The PR description/template explicitly says not to modify src/index.json (it should be updated by the publish pipeline). This change directly edits src/index.json; either revert this file change and update the extension source’s setup.py/HISTORY.rst, or update the PR description to clarify why this is an exception (e.g., external extension without source here).
| "metadata_version": "2.0", | ||
| "name": "arcdata", | ||
| "requires_python": ">=3.10", | ||
| "run_requires": [ |
There was a problem hiding this comment.
This new entry declares requires_python: ">=3.10" but keeps azext.minCliCoreVersion at 2.3.1. Very old CLI core versions may attempt to install the extension and then fail due to the Python requirement; consider bumping azext.minCliCoreVersion to a CLI version that guarantees Python >= 3.10 (or otherwise aligning these fields).
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.