Fix for Fairfax ExtType calls landing on Prod ARM URL#9726
Fix for Fairfax ExtType calls landing on Prod ARM URL#9726prasannajsns wants to merge 1 commit intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @prasannajsns, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
Removes a hard-coded ARM base URL override in the vendored SourceControlConfiguration client so that az k8s-extension extension-types requests respect the Azure CLI cloud’s configured Resource Manager endpoint (e.g., Fairfax) instead of always targeting the public ARM endpoint.
Changes:
- Removed a temporary
_client._base_url = "https://management.azure.com"override from theextension_typesoperation group accessor. - Eliminated the associated “remove after testing” comment for
2023-05-01-preview.
Release SuggestionsModule: k8s-extension
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
please resolve the CI issues |
@yanzhudd - The CI check failures are styling issue in the previously existing code and not newly introduced. We will address them in our next update to the CLI package. Please approve this PR if there are no other comments from your side. |
Fixes an issue where az k8s-extension extension-types commands in Fairfax are routed to public ARM URL
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)