Adding enable ultra ssd, eviction policy, and spot max price support for machine by erinborders · Pull Request #9696 · Azure/azure-cli-extensions

erinborders · 2026-03-17T15:41:52Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks machine add

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-03-17T15:41:57Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter enable_ultra_ssd

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter eviction_policy

⚠️ 1006 - ParaAdd aks machine add cmd aks machine add added parameter spot_max_price

azure-client-tools-bot-prd · 2026-03-17T15:42:01Z

Hi @erinborders,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-03-17T15:43:34Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-03-17T15:43:38Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-03-17T15:47:49Z

Hi @erinborders

Release Suggestions

Module: aks-preview

Update VERSION to 20.0.0b2 in src/aks-preview/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

github-actions · 2026-03-17T15:49:06Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

FumingZhang · 2026-03-17T23:15:20Z

/azp run

azure-pipelines · 2026-03-17T23:15:36Z

Azure Pipelines successfully started running 2 pipeline(s).

src/aks-preview/azext_aks_preview/machine.py

FumingZhang

Could you add some unit tests? It would also be helpful to include a scenario test (e2e test) in test_aks_commands.py.

azure-pipelines · 2026-03-31T00:08:01Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-03-31T00:08:13Z

Re-queued live test. Don't forget to commit the recording file after the live test has passed to ensure the CI checks are successful.

Re-queued live test

FumingZhang · 2026-04-01T00:47:12Z

/azp run

azure-pipelines · 2026-04-01T00:47:25Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-04-02T00:30:24Z

/azp run

azure-pipelines · 2026-04-02T00:30:37Z

Azure Pipelines successfully started running 2 pipeline(s).

…sions into erinborders/machine-preview

FumingZhang · 2026-04-02T04:57:38Z

/azp run

azure-pipelines · 2026-04-02T04:57:52Z

Azure Pipelines successfully started running 2 pipeline(s).

erinborders · 2026-04-02T15:25:38Z

finally got the test to pass and added the recording file to the PR

FumingZhang · 2026-04-07T00:10:23Z

/azp run

azure-pipelines · 2026-04-07T00:10:37Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-04-07T04:54:44Z

src/aks-preview/HISTORY.rst

 +++++++
 * `az aks create/update`: Add `--enable-app-routing-istio` / `--disable-app-routing-istio` (short: `--enable-ari` / `--disable-ari`) flags to enable or disable Istio as a Gateway API implementation for App Routing.
 * `az aks approuting gateway istio enable/disable`: Add new subcommands to enable or disable the Istio Gateway API implementation for App Routing on an existing cluster.
+* `az aks machine add`: Add `--spot-max-price` flag support to set the max price (in US Dollars) you are willing to pay for spot instances on a machine.


Please move your newly added history notes to the Pending section or create a new version tag and update the value of VERSION in setup.py accordingly.

FumingZhang · 2026-04-07T04:56:59Z

src/aks-preview/azext_aks_preview/machine.py

+        operation_group="machines"
+    )
+    machineBillingProfile = MachineBillingProfile(
+        spot_max_price=spot_max_price


There is a normalization of NaN in the AP handling logic. Since the machine is a new feature, it may not yet have comprehensive unit and scenario tests to ensure that NaN values are correctly passed to RP and handled appropriately.

…sions into erinborders/machine-preview

FumingZhang · 2026-04-08T00:34:42Z

/azp run

azure-pipelines · 2026-04-08T00:34:54Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-04-08T01:08:29Z

src/aks-preview/HISTORY.rst

+* `az aks machine add`: Add `--spot-max-price` flag support to set the max price (in US Dollars) you are willing to pay for spot instances on a machine.
+* `az aks machine add`: Add `--eviction-policy` flag support to set the eviction policy for a machine.
+* `az aks machine add`: Add `--enable-ultra-ssd` flag support to enable ultra ssd on a machine.


Please do not add new history notes to a released version. Either choose a new version like 19.0.0b30 or move it to Pending.

FumingZhang · 2026-04-10T03:54:30Z

/azp run

azure-pipelines · 2026-04-10T03:54:45Z

Azure Pipelines successfully started running 2 pipeline(s).

erinborders added 3 commits March 17, 2026 11:22

add spot max price flag

3752bec

enable ultra ssd and eviction policy

b787769

change notes

bf3be79

erinborders requested review from FumingZhang and andyliuliming as code owners March 17, 2026 15:41

Copilot AI review requested due to automatic review settings March 17, 2026 15:41

azure-client-tools-bot-prd bot added this to the April 2026 (2026-04-07) milestone Mar 17, 2026

microsoft-github-policy-service bot requested review from yanzhudd, yonzhan and zhoxing-ms March 17, 2026 15:42

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Mar 17, 2026

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Mar 17, 2026

Copilot started reviewing on behalf of erinborders March 17, 2026 15:46 View session

erinborders added 2 commits March 17, 2026 11:52

linting

2be46ca

linting

ad7b35d

Copilot AI reviewed Mar 17, 2026

View reviewed changes

FumingZhang reviewed Mar 17, 2026

View reviewed changes

src/aks-preview/azext_aks_preview/machine.py Show resolved Hide resolved

FumingZhang reviewed Mar 17, 2026

View reviewed changes

yonzhan unassigned zhoxing-ms Mar 18, 2026

test coverage

72f4df4

parsing

1f06734

test

b01fe8e

erinborders added 3 commits April 1, 2026 23:39

remove readonly zones

0b37b91

zones on machine

4a41531

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

cda4bc1

…sions into erinborders/machine-preview

erinborders added 2 commits April 2, 2026 10:51

fix init params

5de034c

recording file

e942096

FumingZhang reviewed Apr 7, 2026

View reviewed changes

erinborders added 2 commits April 7, 2026 13:21

handle nan and update pending

cf9fbbb

Merge branch 'main' of https://github.com/erinborders/azure-cli-exten…

8e221ee

…sions into erinborders/machine-preview

FumingZhang reviewed Apr 8, 2026

View reviewed changes

move to pending

15c0672

FumingZhang approved these changes Apr 10, 2026

View reviewed changes

yanzhudd approved these changes Apr 10, 2026

View reviewed changes

yanzhudd merged commit e4d708c into Azure:main Apr 10, 2026
24 checks passed

Conversation

erinborders commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Mar 17, 2026

Uh oh!

yonzhan commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Suggestions

Module: aks-preview

Notes

Uh oh!

github-actions bot commented Mar 17, 2026

CodeGen Tools Feedback Collection

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Mar 17, 2026

Uh oh!

azure-pipelines bot commented Mar 17, 2026

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Mar 31, 2026

Uh oh!

FumingZhang commented Mar 31, 2026

Uh oh!

FumingZhang commented Apr 1, 2026

Uh oh!

azure-pipelines bot commented Apr 1, 2026

Uh oh!

FumingZhang commented Apr 2, 2026

Uh oh!

azure-pipelines bot commented Apr 2, 2026

Uh oh!

FumingZhang commented Apr 2, 2026

Uh oh!

azure-pipelines bot commented Apr 2, 2026

Uh oh!

erinborders commented Apr 2, 2026

Uh oh!

FumingZhang commented Apr 7, 2026

Uh oh!

azure-pipelines bot commented Apr 7, 2026

Uh oh!

FumingZhang Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Apr 8, 2026

Uh oh!

azure-pipelines bot commented Apr 8, 2026

Uh oh!

FumingZhang Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Apr 10, 2026

Uh oh!

azure-pipelines bot commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

erinborders commented Mar 17, 2026 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading