refactor: merge Rigidbody2D and Collider2D into PhysicsBody2D#886
Closed
AnthonyWadham wants to merge 2 commits intoAnthony/add-missing-shapesfrom
Closed
refactor: merge Rigidbody2D and Collider2D into PhysicsBody2D#886AnthonyWadham wants to merge 2 commits intoAnthony/add-missing-shapesfrom
AnthonyWadham wants to merge 2 commits intoAnthony/add-missing-shapesfrom
Conversation
This was referenced Apr 7, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
407ce21 to
2974a4f
Compare
82f0d7c to
b84c1ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Consolidated
Rigidbody2DandCollider2Dcomponents into a singlePhysicsBody2Dcomponent that contains both rigid body parameters and collider shapes.What changed?
Collider2Dcomponent and moved itsShapesfield intoPhysicsBody2DRigidbody2DtoPhysicsBody2Dand added the shapes array to itNewPhysicsBody2Dconstructor to accept shapes as variadic parametersPhysicsBody2Dinstead of separateRigidbody2DandCollider2DcomponentsapplyRigidbodyInPlacetoapplyBodyParamsInPlaceandRigidbodyDifferstoBodyParamsDifferWhy make this change?
This consolidation simplifies the physics component architecture by combining related data (rigid body properties and collision shapes) into a single component, reducing the complexity of managing separate but tightly coupled components and making the physics system more cohesive.