Skip to content

fix namespace persistence #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvmassen wants to merge 1 commit into
base: dev
Choose a base branch
from
+12 −4
Open

fix namespace persistence #2557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions appdaemon/models/config/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,24 @@ class FilterConfig(BaseModel):

class NamespaceConfig(BaseModel):
writeback: ADWritebackType | None = None
persist: bool = Field(default=False, alias="persistent")
persist: bool = Field(default=False)
save_interval: ParsedTimedelta = Field(default=timedelta(seconds=1))

@model_validator(mode="before")
@classmethod
def validate_persistence(cls, values: Any):
"""Sets persistence to True if writeback is set to safe or hybrid."""
"""Sets persistence to True if writeback is set to safe or hybrid.

Also handles backward compatibility by converting the legacy 'persistent'
field name to 'persist'.
"""
match values:
case {"writeback": wb} if wb is not None:
values["persist"] = True
case dict():
# Handle backward compatibility: convert 'persistent' to 'persist'
if "persistent" in values:
values["persist"] = values.pop("persistent")
if values.get("writeback") is not None:
values["persist"] = True
case _ if getattr(values, "writeback", None) is not None:
values.persist = True
return values
Expand Down