Refactor Kokkos functors to 3D MDRange, remove SIMD specializations, and update Field view#23
Open
Amazingkivas wants to merge 2 commits intomainfrom
Open
Refactor Kokkos functors to 3D MDRange, remove SIMD specializations, and update Field view#23Amazingkivas wants to merge 2 commits intomainfrom
Amazingkivas wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Kokkos::Viewmemory traits and the projectFPtypedef.Description
ComputeE_FieldFunctorandComputeB_FieldFunctorto use a 3DKokkos::MDRangePolicyand updated theiroperator()signatures from(const int& k, const int& j)to(const int& k, const int& j, const int& i)with flattened 3D indexing.simd_type,simd_width,start_i/end_i, andKokkos_SIMD.hppusage) and replaced with scalar per-index updates and simpler periodic-boundary handling.kokkos_shared.hto removeKokkos_SIMD.hpp, switchFieldtoKokkos::View<FP*, Kokkos::MemoryTraits<Kokkos::Restrict | Kokkos::Aligned>>, and use the projectFPtype consistently.coef_dz(ensuring it is passed by reference) and simplified index computations for neighbor accesses (i_pred_idx,j_pred_idx,k_pred_idx/scalar_*_idx).Testing
Codex Task