Use 3D Kokkos MDRangePolicy and remove manual SIMD loops in ComputeE/ComputeB functors#22
Open
Amazingkivas wants to merge 1 commit intomainfrom
Open
Use 3D Kokkos MDRangePolicy and remove manual SIMD loops in ComputeE/ComputeB functors#22Amazingkivas wants to merge 1 commit intomainfrom
Amazingkivas wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
(k, j, i)and computes flat indices consistently.Description
start_i/end_imembers and all SIMD/unrolled loop code paths fromComputeE_FieldFunctorandComputeB_FieldFunctor, and replaced them with an element-wise implementation using a 3DKokkos::MDRangePolicy.applyfunctions to create a 3D MDRangePolicy (with explicit iteration order) using{bounds_k[0], bounds_j[0], bounds_i[0]}->{bounds_k[1], bounds_j[1], bounds_i[1]}and adjusted parameter lists accordingly, including makingcoef_dzaconst FP&.operator()signatures tooperator()(const int& k, const int& j, const int& i) const, computed the flattenedindex, and replaced the SIMD neighbor-index logic with scalar neighbor index calculations (e.g.i_pred_idx,j_pred_idx,k_pred_idx) and periodic boundary handling.ComputeB_FieldFunctorso both field-update functors use the same 3D policy and indexing approach.Testing
Codex Task