fix: add identifier field to Nodes models in manifest_v12#98
Merged
Sourabhchrs93 merged 1 commit intomainfrom Apr 6, 2026
Merged
fix: add identifier field to Nodes models in manifest_v12#98Sourabhchrs93 merged 1 commit intomainfrom
Sourabhchrs93 merged 1 commit intomainfrom
Conversation
The backend's `extraction_helpers.py` accesses `node.identifier` on Nodes objects, but only Sources models had this field. When `node.alias` is falsy, the fallback to `node.identifier` raises `AttributeError` on Pydantic v2 models, crashing dbt cloud batch ingestion. Adds `identifier: Optional[str] = None` to all 8 Nodes variants (Nodes through Nodes7) in manifest_v12.py. Affected batches (all docusign tenant): - 1401714, 1401603, 1401599, 1396367, 1396366, 1391223 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identifier: Optional[str] = Noneto all 8Nodesmodel variants (NodesthroughNodes7) inmanifest_v12.pyAttributeError: 'Nodes3' object has no attribute 'identifier'crash during dbt cloud batch ingestionRoot Cause
The backend's
extraction_helpers.py:157doesnode.alias or node.identifier or node.unique_id. Whennode.aliasis falsy, Python evaluatesnode.identifier, which raisesAttributeErrorbecause onlySourcesmodels had this field — notNodesmodels.Impact
6 docusign ingestion batches failed with this error:
Test plan
Nodes3(and all other Nodes variants) can be instantiated withoutidentifiernode.identifierreturnsNoneinstead of raisingAttributeError🤖 Generated with Claude Code