ALICE3-TRK: adapt ordering key for digits to the large number of columns in the VD#15070
Open
atriolo wants to merge 1 commit intoAliceO2Group:devfrom
Open
ALICE3-TRK: adapt ordering key for digits to the large number of columns in the VD#15070atriolo wants to merge 1 commit intoAliceO2Group:devfrom
atriolo wants to merge 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the VD case, the sensor covers the full z acceptance of the layer, from z=-25 to z=25 cm, for a total of 50000 columns for a single sensor.
When the number of columns exceeded 32768 = 2^15, the function getOrderingKey(...), which uniquely assigns an ID to each digit, was not working properly anymore.
Issue explained here.
The issue is solved with this commit by casting the column variable to 64-bit before the bit-to-bit shift operated in the function.
This modification is applied only to the TRK class.