Rename language server to objc-clangd to fix builtin conflict#2
Rename language server to objc-clangd to fix builtin conflict#2rodrigopex wants to merge 2 commits intoAkzestia:mainfrom
Conversation
be1edcb to
dcd0ea6
Compare
0a75c24 to
ba1740e
Compare
|
Hi @rodrigopex, Thanks for opening a PR, there is indeed an issue with language server not being registered because of the Zed's built in one. However there are a couple things to consider. 1. Issue with Zed itselfWhen I was trying to reproduce the issue I stumbled on a weird bug. If you have Objective-C extensions already installed, when you launch Zed you will get And the language server won't be registered
but for some reason if you will just reinstall the extension (without leaving Zed afterwards), it will override default
2. Issues with your PRFirst of all this one: [language_servers.objcpp-clangd]
name = "objcpp-clangd"
languages = ["Objective-C", "Objective-C++"]The languages/Objective-Cwhich will only register
Coming next, can you elaborate why you decided to change this one: let path = worktree
.which("clangd")
.ok_or_else(|| "objcpp-clangd: clangd must be installed and available in PATH".to_string())?;From my pov And finally changes to README.md Since Zed has a built-in {
"languages": {
"Objective-C": {
"language_servers": ["objcpp-clangd", "!clangd"]
},
"Objective-C++": {
"language_servers": ["objcpp-clangd", "!clangd"]
}
}
}If Zed doesn't recognize {
"file_types": {
"Objective-C": ["m", "mm"]
}
}As I've already mentioned previously [language_servers.objc-clangd]
name = "objc-clangd"For the part where you added name = "Objective-C"
grammar = "objc"
path_suffixes = ["mm", "m", "hh", "h"]I'd appreciate your feedback on the matter |



Summary
Test plan