Allow disabling rate limiting for users via exceptions list from core#617
Merged
bitterpanda63 merged 1 commit intomainfrom Apr 13, 2026
Merged
Allow disabling rate limiting for users via exceptions list from core#617bitterpanda63 merged 1 commit intomainfrom
bitterpanda63 merged 1 commit intomainfrom
Conversation
| received_any_stats=res.get("receivedAnyStats", True), | ||
| ) | ||
|
|
||
| # Handle excluded user IDs from rate limiting |
There was a problem hiding this comment.
Inline comment only restates the code's action; prefer explaining why excludedUserIdsFromRateLimiting matters or remove the comment.
Suggested change
| # Handle excluded user IDs from rate limiting | |
| # Apply server-configured exemptions to allow specific users to bypass rate limiting |
Details
✨ AI Reasoning
The new inline comment merely restates the purpose of the following code block (pulling excluded user IDs from the response). It doesn't provide context about expected shape, backward compatibility, or why this field matters, so it is a low-value 'what' comment.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
hansott
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Aikido
⚡ Enhancements
More info