Skip to content

[balancewebhooks] Code generation: update services and models#1819

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balancewebhooks
Open

[balancewebhooks] Code generation: update services and models#1819
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balancewebhooks

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balancewebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balancewebhooks branch from e32cc8b to 6322660 Compare March 27, 2026 11:26
@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 27, 2026 11:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several unused imports from the MessageHeaderTest class. A review comment suggests that instead of removing the assertNotNull import, it should be used to verify that the MessageHeader is correctly deserialized, which would enhance the test's robustness and provide clearer error messages.

package com.adyen.model.nexo;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this import is unused in the current code, consider re-adding it and using assertNotNull to verify that the deserializedMessageHeader object is not null after deserialization. This improves test clarity and provides a more specific error message if terminalApiGson.fromJson were to return null, which can aid in faster debugging.

For example, you could add the following after line 20:

assertNotNull(deserializedMessageHeader);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant