Improve test coverage for service and controller layers#104
Open
Improve test coverage for service and controller layers#104
Conversation
Add unit tests for OpenApiOperationService, WorkflowService and additional WorkflowController scenarios, increasing total tests from 18 to 38. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves unit test coverage from 18 to 38 tests by adding tests for previously untested classes.
New test classes
OpenApiOperationServiceTest— coversisUrl,extractExampleByName, andgetRootFolderwith various inputsWorkflowServiceTest— coversgetFromContentandgetFromUrlscenarios using Mockito to mockFileServiceExtended test class
WorkflowControllerTest— adds tests for components assertion and exception propagation (InvalidContentException,UnexpectedErrorException)Also updates the
openapi-workflow-parserdependency to0.0.5-SNAPSHOT.