fix: Break retain cycle in CommandPalettePanel#112
Conversation
The onSelect and onDismiss closures captured `panel` strongly while panel owned the view controller that stored those closures, creating a cycle (panel → vc → closures → panel) that leaked memory on every dismiss. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Summary
onSelectandonDismissclosures inCommandPalettePanel.show()capturedpanelstrongly, whilepanelowned the view controller that stored those closurespanel→contentViewController→closures→panel) that leaked memory every time the command palette was shown and dismissed[weak panel]captures in both closuresTest plan
🤖 Generated with Claude Code