fix: Add missing Swift field and correct error messages#110
fix: Add missing Swift field and correct error messages#1102witstudios wants to merge 1 commit intomainfrom
Conversation
- Swift AgentEntry was missing suspendedAt field that Rust serializes, causing silent data loss when decoding manifest JSON - CliError::DaemonNotRunning incorrectly suggested "pu spawn" (which spawns agents, not the daemon) instead of pointing to the log file - Strengthen KillTargetRequired test to verify all three flags are present Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
AgentEntrymissingsuspendedAt: Rust'sAgentEntryserializessuspended_atassuspendedAtin JSON, but the Swift model didn't declare this field or CodingKey, silently dropping the data during decodeDaemonNotRunningerror message: Said "runpu spawnto start it" butpu spawnspawns agents — the daemon auto-starts viaensure_daemon(). Now points to the daemon log file insteadKillTargetRequiredtest used||so it would pass even if--worktreeor--allwere removed from the message. Changed to&&to verify all three flagsTest plan
cargo test— all 62 tests pass (including the strengthened assertion)suspendedAtfield🤖 Generated with Claude Code