Skip to content

fix: Add missing Swift field and correct error messages#110

Open
2witstudios wants to merge 1 commit intomainfrom
pu/fix-1
Open

fix: Add missing Swift field and correct error messages#110
2witstudios wants to merge 1 commit intomainfrom
pu/fix-1

Conversation

@2witstudios
Copy link
Owner

Summary

  • Swift AgentEntry missing suspendedAt: Rust's AgentEntry serializes suspended_at as suspendedAt in JSON, but the Swift model didn't declare this field or CodingKey, silently dropping the data during decode
  • Wrong DaemonNotRunning error message: Said "run pu spawn to start it" but pu spawn spawns agents — the daemon auto-starts via ensure_daemon(). Now points to the daemon log file instead
  • Weak test assertion: KillTargetRequired test used || so it would pass even if --worktree or --all were removed from the message. Changed to && to verify all three flags

Test plan

  • cargo test — all 62 tests pass (including the strengthened assertion)
  • Verify Swift project builds with the new suspendedAt field

🤖 Generated with Claude Code

- Swift AgentEntry was missing suspendedAt field that Rust serializes,
  causing silent data loss when decoding manifest JSON
- CliError::DaemonNotRunning incorrectly suggested "pu spawn" (which
  spawns agents, not the daemon) instead of pointing to the log file
- Strengthen KillTargetRequired test to verify all three flags are present

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026

Warning

Rate limit exceeded

@2witstudios has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8c863f2-1f71-4fa6-a373-f43407e81e4a

📥 Commits

Reviewing files that changed from the base of the PR and between 55aa882 and 22ec0e9.

📒 Files selected for processing (3)
  • apps/purepoint-macos/purepoint-macos/Models/ManifestModel.swift
  • crates/pu-cli/src/error.rs
  • crates/pu-core/src/error.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pu/fix-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant