Closed
Conversation
Collaborator
Author
|
Closing in favor of #1784 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This PR updates the protocol version to the next branch. It currently has the following issue that needs to be address before continuing:
The protocol uses version 0.22 of the
cryptorepository, the same version that the VM uses. That version currently does not haveStorageErrorandSubtreeUpdateexposed, and we are using those structs in the rocksdb crate of this repository. @drahnr already created a new commit on top of 0.22 with the needed changes for thecryptorepository, exposing the structs.I updated the protocol version to use that branch in particular, but it is failing to compile due to the
miden-vmrepository having pinned the "0.22" version from crates.io and thus not using the repository one.Related: #1720 (comment)
Maybe I'm not having something in mind after the releases/versions recent changes; am I doing the proper approach? Should I update this in some other way?
cc @Mirko-von-Leipzig